Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix misc console errors and warnings #6083

Merged
merged 4 commits into from
Jun 25, 2024
Merged

Fix misc console errors and warnings #6083

merged 4 commits into from
Jun 25, 2024

Conversation

st3iny
Copy link
Member

@st3iny st3iny commented Jun 25, 2024

Resolves #6080

Fixes all console warnings and errors I encountered.

st3iny added 2 commits June 25, 2024 19:18
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
@st3iny st3iny added 3. to review Waiting for reviews bug labels Jun 25, 2024
@st3iny st3iny self-assigned this Jun 25, 2024
@st3iny st3iny added this to the v4.8.0 milestone Jun 25, 2024
st3iny added 2 commits June 25, 2024 19:50
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
@st3iny st3iny force-pushed the fix/frontend-warnings branch from eb16ad8 to 4ca0dca Compare June 25, 2024 17:51
Base automatically changed from Migrate/vuex-to-pinia to main June 25, 2024 17:51
@st3iny st3iny enabled auto-merge June 25, 2024 17:51
@st3iny st3iny added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jun 25, 2024
Copy link

codecov bot commented Jun 25, 2024

Codecov Report

Attention: Patch coverage is 0% with 10 lines in your changes missing coverage. Please review.

Project coverage is 29.71%. Comparing base (88f6dd2) to head (4ca0dca).
Report is 11 commits behind head on main.

Files Patch % Lines
src/components/AppNavigation/Settings.vue 0.00% 3 Missing ⚠️
...pNavigation/Settings/SettingsAttachmentsFolder.vue 0.00% 3 Missing ⚠️
src/views/EditSimple.vue 0.00% 3 Missing ⚠️
...rc/components/Editor/Properties/PropertySelect.vue 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #6083      +/-   ##
============================================
+ Coverage     24.02%   29.71%   +5.69%     
- Complexity      457      914     +457     
============================================
  Files           246      287      +41     
  Lines         11569    13835    +2266     
  Branches       2163     2163              
============================================
+ Hits           2779     4111    +1332     
- Misses         8475     9409     +934     
  Partials        315      315              
Flag Coverage Δ
javascript 15.57% <0.00%> (+<0.01%) ⬆️
php 58.65% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@st3iny st3iny merged commit e885970 into main Jun 25, 2024
41 of 42 checks passed
@st3iny st3iny deleted the fix/frontend-warnings branch June 25, 2024 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Console errors when editing or viewing events
2 participants