ci: allow coverage upload to fail #6149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6149 +/- ##
=========================================
Coverage 29.84% 29.84%
Complexity 914 914
=========================================
Files 289 289
Lines 13768 13768
Branches 2165 2165
=========================================
Hits 4109 4109
+ Misses 9345 9344 -1
- Partials 314 315 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Otherwise, PRs from (community) forks will never have green CI. In my opinion we can tolerate having no coverage info from the occasional community contributor as long as the tests are successful. Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
st3iny
force-pushed
the
ci/allow-codecov-failure
branch
from
8674d1b to
9802787
Compare
ChristophWurst
approved these changes
Jul 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise, PRs from (community) forks will never have green CI. In my opinion we can tolerate having no coverage info from the occasional community contributor as long as the tests are successful.