Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: require caldav backend #6170

Merged
merged 1 commit into from
Jul 22, 2024
Merged

feat: require caldav backend #6170

merged 1 commit into from
Jul 22, 2024

Conversation

st3iny
Copy link
Member

@st3iny st3iny commented Jul 16, 2024

Will be required after nextcloud/server#46510

Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
@st3iny st3iny self-assigned this Jul 16, 2024
@st3iny st3iny marked this pull request as draft July 16, 2024 07:37
@st3iny st3iny added the 2. developing Work in progress label Jul 16, 2024
Copy link

codecov bot commented Jul 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 23.97%. Comparing base (6d1a23d) to head (5b3293f).
Report is 40 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #6170      +/-   ##
============================================
- Coverage     23.97%   23.97%   -0.01%     
  Complexity      457      457              
============================================
  Files           247      247              
  Lines         11605    11606       +1     
  Branches       2177     2188      +11     
============================================
  Hits           2782     2782              
  Misses         8508     8508              
- Partials        315      316       +1     
Flag Coverage Δ
javascript 15.46% <ø> (ø)
php 59.53% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@st3iny st3iny marked this pull request as ready for review July 22, 2024 12:30
@st3iny st3iny added 3. to review Waiting for reviews enhancement New feature request and removed 2. developing Work in progress labels Jul 22, 2024
@st3iny st3iny added this to the v5.0.0 milestone Jul 22, 2024
@miaulalala miaulalala merged commit 9480cc3 into main Jul 22, 2024
42 of 43 checks passed
@miaulalala miaulalala deleted the feat/require-caldav-backend branch July 22, 2024 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews enhancement New feature request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants