Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(notifications): Notifier::prepare() threw \InvalidArgumentExcepti… #6587

Merged
merged 1 commit into from
Dec 20, 2024

Conversation

nickvergessen
Copy link
Member

…on which is deprecated

Possible since Nextcloud 30, and that's the minimum on main, so should be okay?

If a user has any notifications this log is generated all the time:

OCA\Calendar\Notification\Notifier::prepare() threw \InvalidArgumentException which is deprecated. Throw \OCP\Notification\UnknownNotificationException when the notification is not known to your notifier and otherwise handle all \InvalidArgumentException yourself

…on which is deprecated

Signed-off-by: Joas Schilling <coding@schilljs.com>
Copy link

codecov bot commented Dec 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 23.40%. Comparing base (91d787c) to head (2ab1b8f).
Report is 9 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #6587   +/-   ##
=========================================
  Coverage     23.40%   23.40%           
  Complexity      472      472           
=========================================
  Files           249      249           
  Lines         11901    11901           
  Branches       2283     2272   -11     
=========================================
  Hits           2786     2786           
  Misses         8788     8788           
  Partials        327      327           
Flag Coverage Δ
javascript 14.84% <ø> (ø)
php 59.45% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nickvergessen nickvergessen merged commit c2d1a4b into main Dec 20, 2024
39 checks passed
@nickvergessen nickvergessen deleted the bugfix/noid/notification-handling branch December 20, 2024 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants