Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: keyboard shortcut modal not being responsive #6727

Merged
merged 1 commit into from
Feb 17, 2025

Conversation

st3iny
Copy link
Member

@st3iny st3iny commented Feb 17, 2025

Fix #6726

Screenshots

Before

(No scroll bar.)

Image

After

Normal screen Small screen
spectacle_20250217_171733 spectacle_20250217_172153

@st3iny st3iny added 3. to review Waiting for reviews bug design Related to design, interface, interaction design, UX, etc. regression Regression of a previous working feature labels Feb 17, 2025
@st3iny st3iny added this to the v5.2.0 milestone Feb 17, 2025
@st3iny st3iny requested a review from GretaD February 17, 2025 16:25
@st3iny st3iny self-assigned this Feb 17, 2025
@st3iny
Copy link
Member Author

st3iny commented Feb 17, 2025

/backport to stable5.1

@backportbot backportbot bot added the backport-request A backport was requested for this pull request label Feb 17, 2025
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
@st3iny st3iny force-pushed the fix/keyboard-shortcut-design branch from 1f93c1a to 1ecf27b Compare February 17, 2025 16:26
Copy link

codecov bot commented Feb 17, 2025

Codecov Report

Attention: Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.

Project coverage is 23.01%. Comparing base (caf5cf8) to head (1ecf27b).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
...onents/AppNavigation/Settings/ShortcutOverview.vue 0.00% 9 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #6727      +/-   ##
============================================
- Coverage     23.01%   23.01%   -0.01%     
  Complexity      475      475              
============================================
  Files           252      252              
  Lines         12105    12106       +1     
  Branches       2296     2309      +13     
============================================
  Hits           2786     2786              
- Misses         8993     8994       +1     
  Partials        326      326              
Flag Coverage Δ
javascript 14.54% <0.00%> (-0.01%) ⬇️
php 59.30% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@st3iny
Copy link
Member Author

st3iny commented Feb 17, 2025

/backport to stable4.7

@st3iny
Copy link
Member Author

st3iny commented Feb 17, 2025

/backport to stable5.0

@st3iny
Copy link
Member Author

st3iny commented Feb 17, 2025

/backport to stable5.1

@st3iny st3iny merged commit ef8421e into main Feb 17, 2025
48 of 49 checks passed
@st3iny st3iny deleted the fix/keyboard-shortcut-design branch February 17, 2025 19:30
@backportbot backportbot bot removed the backport-request A backport was requested for this pull request label Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug design Related to design, interface, interaction design, UX, etc. regression Regression of a previous working feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Keyboard shortcuts is not responsive
2 participants