Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable5.1] Visually distinguish invitations in calendar grid #6729

Closed
wants to merge 1 commit into from
Closed

[stable5.1] Visually distinguish invitations in calendar grid #6729

wants to merge 1 commit into from

Conversation

backportbot[bot]
Copy link

@backportbot backportbot bot commented Feb 17, 2025

Backport of PR #6624

@GVodyanov @backportbot
feat(FullCalendar): add conditional styling for participation status …
a7d6c27 
…in grid

Signed-off-by: Grigory Vodyanov <scratchx@gmx.com>
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
@backportbot backportbot bot added 3. to review Waiting for reviews design Related to design, interface, interaction design, UX, etc. enhancement New feature request Feature: Fullcalendar labels Feb 17, 2025
@backportbot backportbot bot added this to the v5.1.0 milestone Feb 17, 2025
@codecov Codecov
Copy link

codecov bot commented Feb 17, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 14.70588% with 58 lines in your changes missing coverage. Please review.

Project coverage is 14.58%. Comparing base (6aff663) to head (a7d6c27).
Report is 3 commits behind head on stable5.1.

Files with missing lines Patch % Lines
src/fullcalendar/rendering/eventDidMount.js 12.24% 37 Missing and 6 partials ⚠️
...c/fullcalendar/eventSources/eventSourceFunction.js 21.05% 8 Missing and 7 partials ⚠️
Additional details and impacted files 
@@              Coverage Diff              @@
##           stable5.1    #6729      +/-   ##
=============================================
+ Coverage      14.55%   14.58%   +0.03%     
=============================================
  Files            210      210              
  Lines           9813     9879      +66     
  Branches        2308     2329      +21     
=============================================
+ Hits            1428     1441      +13     
- Misses          8059     8099      +40     
- Partials         326      339      +13
Flag Coverage Δ
javascript 14.58% <14.70%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@st3iny
Copy link
Member

st3iny commented Feb 17, 2025

Will be part of the next minor release.

@st3iny st3iny closed this Feb 17, 2025
@st3iny st3iny deleted the backport/6624/stable5.1 branch February 17, 2025 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SebastianKrupinski SebastianKrupinski Awaiting requested review from SebastianKrupinski SebastianKrupinski is a code owner

@st3iny st3iny Awaiting requested review from st3iny st3iny is a code owner

@tcitworld tcitworld Awaiting requested review from tcitworld tcitworld is a code owner

@nimishavijay nimishavijay Awaiting requested review from nimishavijay

@GVodyanov GVodyanov Awaiting requested review from GVodyanov

Assignees

@GVodyanov GVodyanov

Labels
3. to review Waiting for reviews design Related to design, interface, interaction design, UX, etc. enhancement New feature request Feature: Fullcalendar
Projects
None yet
Milestone
v5.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@st3iny @GVodyanov