Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable5.0] fix: keyboard shortcut modal not being responsive #6731

Merged
merged 1 commit into from
Feb 17, 2025

Conversation

backportbot[bot]
Copy link

@backportbot backportbot bot commented Feb 17, 2025

Backport of PR #6727

Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
@backportbot backportbot bot requested a review from tcitworld as a code owner February 17, 2025 19:30
@backportbot backportbot bot added 3. to review Waiting for reviews bug design Related to design, interface, interaction design, UX, etc. regression Regression of a previous working feature labels Feb 17, 2025
@backportbot backportbot bot added this to the v5.0.2 milestone Feb 17, 2025
Copy link

codecov bot commented Feb 17, 2025

Codecov Report

Attention: Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.

Project coverage is 15.41%. Comparing base (5ef9b1e) to head (3eae428).
Report is 6 commits behind head on stable5.0.

Files with missing lines Patch % Lines
...onents/AppNavigation/Settings/ShortcutOverview.vue 0.00% 9 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##           stable5.0    #6731      +/-   ##
=============================================
- Coverage      15.41%   15.41%   -0.01%     
=============================================
  Files            206      206              
  Lines           9451     9452       +1     
  Branches        2192     2193       +1     
=============================================
  Hits            1457     1457              
- Misses          7676     7677       +1     
  Partials         318      318              
Flag Coverage Δ
javascript 15.41% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@st3iny st3iny merged commit 1e83325 into stable5.0 Feb 17, 2025
30 of 31 checks passed
@st3iny st3iny deleted the backport/6727/stable5.0 branch February 17, 2025 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug design Related to design, interface, interaction design, UX, etc. regression Regression of a previous working feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant