Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(l10n): add context for translators (second vs. seconds) #6760

Merged
merged 1 commit into from
Feb 21, 2025

Conversation

st3iny
Copy link
Member

@st3iny st3iny commented Feb 20, 2025

Ref #3441 (comment)

Add context for translators to disambiguate second and seconds.

Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
@st3iny st3iny added 3. to review Waiting for reviews language l10n and translations labels Feb 20, 2025
@st3iny st3iny added this to the v5.2.0 milestone Feb 20, 2025
@st3iny st3iny self-assigned this Feb 20, 2025
@st3iny
Copy link
Member Author

st3iny commented Feb 20, 2025

/backport to stable4.7

@backportbot backportbot bot added the backport-request A backport was requested for this pull request label Feb 20, 2025
@st3iny
Copy link
Member Author

st3iny commented Feb 20, 2025

/backport to stable5.1

Copy link

codecov bot commented Feb 20, 2025

Codecov Report

Attention: Patch coverage is 20.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 23.00%. Comparing base (fb09abe) to head (9d76c8c).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
...components/Editor/Repeat/RepeatFirstLastSelect.vue 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##               main    #6760   +/-   ##
=========================================
  Coverage     23.00%   23.00%           
  Complexity      476      476           
=========================================
  Files           252      252           
  Lines         12174    12174           
  Branches       2329     2330    +1     
=========================================
  Hits           2801     2801           
  Misses         9034     9034           
  Partials        339      339           
Flag Coverage Δ
javascript 14.58% <20.00%> (ø)
php 59.33% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@st3iny st3iny merged commit f14909e into main Feb 21, 2025
46 of 47 checks passed
@st3iny st3iny deleted the fix/l10n/second-context branch February 21, 2025 06:35
@backportbot backportbot bot removed the backport-request A backport was requested for this pull request label Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews language l10n and translations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants