From 9d76c8c5a3487c58732fe193155a59d59c1a5861 Mon Sep 17 00:00:00 2001
From: Richard Steinmetz <richard@steinmetz.cloud>
Date: Thu, 20 Feb 2025 23:28:40 +0100
Subject: [PATCH] fix(l10n): add context for translators (second vs. seconds)

Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
---
 .../Editor/Repeat/RepeatFirstLastSelect.vue   | 27 ++++---------------
 src/filters/recurrenceRuleFormat.js           |  3 ++-
 2 files changed, 7 insertions(+), 23 deletions(-)

diff --git a/src/components/Editor/Repeat/RepeatFirstLastSelect.vue b/src/components/Editor/Repeat/RepeatFirstLastSelect.vue
index 8bd009d98a..0a7cf817b3 100644
--- a/src/components/Editor/Repeat/RepeatFirstLastSelect.vue
+++ b/src/components/Editor/Repeat/RepeatFirstLastSelect.vue
@@ -17,6 +17,7 @@
 
 <script>
 import { NcSelect } from '@nextcloud/vue'
+import { getTranslatedOrdinalNumber } from '../../../filters/recurrenceRuleFormat.js'
 
 export default {
 	name: 'RepeatFirstLastSelect',
@@ -41,28 +42,10 @@ export default {
 	},
 	computed: {
 		options() {
-			return [{
-				label: this.$t('calendar', 'first'),
-				value: 1,
-			}, {
-				label: this.$t('calendar', 'second'),
-				value: 2,
-			}, {
-				label: this.$t('calendar', 'third'),
-				value: 3,
-			}, {
-				label: this.$t('calendar', 'fourth'),
-				value: 4,
-			}, {
-				label: this.$t('calendar', 'fifth'),
-				value: 5,
-			}, {
-				label: this.$t('calendar', 'second to last'),
-				value: -2,
-			}, {
-				label: this.$t('calendar', 'last'),
-				value: -1,
-			}]
+			return [1, 2, 3, 4, 5, -2, -1].map((ordinal) => ({
+				label: getTranslatedOrdinalNumber(ordinal),
+				value: ordinal,
+			}))
 		},
 		selected() {
 			return this.options.find(option => option.value === this.bySetPosition)
diff --git a/src/filters/recurrenceRuleFormat.js b/src/filters/recurrenceRuleFormat.js
index 7ef0483961..4e071b9824 100644
--- a/src/filters/recurrenceRuleFormat.js
+++ b/src/filters/recurrenceRuleFormat.js
@@ -185,12 +185,13 @@ function getTranslatedMonths(byMonthList) {
  * @param {number} bySetPositionNum The by-set-position number to get the translation of
  * @return {string}
  */
-function getTranslatedOrdinalNumber(bySetPositionNum) {
+export function getTranslatedOrdinalNumber(bySetPositionNum) {
 	switch (bySetPositionNum) {
 	case 1:
 		return t('calendar', 'first')
 
 	case 2:
+		// TRANSLATORS This refers to the second item in a series, not to the unit of time
 		return t('calendar', 'second')
 
 	case 3: