fix: do not show hidden calendars #6770
Conversation
Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>
SebastianKrupinski
requested review from
st3iny and
tcitworld
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6770 +/- ##
=========================================
Coverage 23.00% 23.01%
- Complexity 476 479 +3
=========================================
Files 252 252
Lines 12174 12176 +2
Branches 2330 2317 -13
=========================================
+ Hits 2801 2802 +1
- Misses 9034 9035 +1
Partials 339 339
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
SebastianKrupinski
requested review from
ChristophWurst,
kesselb and
hamza221
SebastianKrupinski
added
3. to review
|
The failed tests are due to the missing class on server the required PR needs to be merged |
|
This app works with Nextcloud 30. CI for 30 and 31 will still fail even when the server PR is in. Just FYI. |
Yes, the idea was to back port the server side to 30 and 31 |
lib/Dashboard/CalendarWidget.php
Outdated
| @@ -124,6 +125,9 @@ public function getItems(string $userId, ?string $since = null, int $limit = 7): | |||
| ]; | |||
| $widgetItems = []; | |||
| foreach ($calendars as $calendar) { | |||
| if ($calendar instanceof ICalendarIsEnabled && $calendar->isEnabled() === false) { | |||
There was a problem hiding this comment.
Needs to be guarded by if (interface_exists(ICalendarIsEnabled::class)) { ... } until we are sure that this interface is always available.
Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>
Resolves: #6767
Requires: nextcloud/server#51081