Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(pinia): migrate integrationsStore to Pinia #11306

Merged
merged 1 commit into from
Dec 29, 2023
Merged

chore(pinia): migrate integrationsStore to Pinia #11306

merged 1 commit into from
Dec 29, 2023

Conversation

Antreesy
Copy link
Contributor

☑️ Resolves

  • Migrate the store for other app integrated actions to Pinia

Tip

To test messageActions, install Deck app
To test participantSearchActions, install Guests app (might need to force enable it)

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

No visual changes

🏁 Checklist

  • 🌏 Tested with Chrome, Firefox and Safari or should not be risky to browser differences
  • ⛑️ Tests are included or not possible

@Antreesy
fix(pinia): migrate integrations store to Pinia
e257a93 
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy Antreesy added this to the 💞 Following Major (29) milestone Dec 28, 2023
@Antreesy Antreesy requested a review from DorraJaouad December 28, 2023 15:58
@Antreesy Antreesy self-assigned this Dec 28, 2023
DorraJaouad
DorraJaouad approved these changes Dec 29, 2023
View reviewed changes
Copy link
Contributor

@DorraJaouad DorraJaouad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code-wise, nothing is blocking.
Tested with Guests app.

@Antreesy Antreesy merged commit e8472e9 into main Dec 29, 2023
36 checks passed
@Antreesy Antreesy deleted the feat/noid/integrations-store-pinia branch December 29, 2023 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DorraJaouad DorraJaouad DorraJaouad approved these changes

Assignees

@Antreesy Antreesy

Labels
3. to review feature: frontend 🖌️ "Web UI" client technical debt
Projects
None yet
Milestone
v19.0.0-beta.1
Development

Successfully merging this pull request may close these issues.
2 participants
@Antreesy @DorraJaouad