Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(vue3): eslint #12378

Merged
merged 6 commits into from
May 17, 2024
Merged

chore(vue3): eslint #12378

merged 6 commits into from
May 17, 2024

Conversation

ShGKme
Copy link
Contributor

@ShGKme ShGKme commented May 16, 2024

☑️ Resolves

@ShGKme ShGKme requested review from DorraJaouad and Antreesy May 16, 2024 19:18
@ShGKme ShGKme self-assigned this May 16, 2024
This was referenced May 16, 2024
Closed
Open
ShGKme added 6 commits May 16, 2024 23:24
@ShGKme
chore(vue3): migrate to ESLint with Vue 3 plugin
bd56850 
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme
chore(vue3): lint vue/no-deprecated-v-bind-sync
48b9ee5 
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme
chore(vue3): lint vue/v-on-event-hyphenation
03e749a 
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme
chore(vue3): lint vue/no-deprecated-destroyed-lifecycle
81d2084 
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme
chore(vue3): lint vue/attributes-order
08109d3 
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme
chore(vue3): lint vue/custom-event-name-casing
084428a 
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme ShGKme force-pushed the chore/eslint-for-vue3 branch from d014371 to 084428a Compare May 16, 2024 21:25
@ShGKme
Copy link
Contributor Author

ShGKme commented May 16, 2024

Rebased onto vue3, now ESLint must be green 🎉

This was referenced May 16, 2024
Closed
Merged
Antreesy
Antreesy approved these changes May 17, 2024
View reviewed changes
Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did a smoke test, seems to work properly 😉

@Antreesy Antreesy merged commit ef544f6 into vue3 May 17, 2024
43 of 44 checks passed
@Antreesy Antreesy deleted the chore/eslint-for-vue3 branch May 17, 2024 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DorraJaouad DorraJaouad DorraJaouad approved these changes

@Antreesy Antreesy Antreesy approved these changes

Assignees

@ShGKme ShGKme

Labels
3. to review feature: frontend 🖌️ "Web UI" client technical debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ShGKme @DorraJaouad @Antreesy