feat(conversation): add federated typing indicator #14443
+31
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickvergessen
force-pushed
the
feat/federated-typing-indicators
branch
from
da6264e to
722e190
Compare
miaulalala
force-pushed
the
feat/federated-typing-indicators
branch
from
722e190 to
edec72e
Compare
| @@ -40,7 +40,6 @@ public function overwrittenRemoteTalkHash(string $hash): string { | |||
| 'config' => [ | |||
| 'chat' => [ | |||
| 'read-privacy', | |||
| 'typing-privacy', | |||
There was a problem hiding this comment.
it's still overwritten, just not with a hardcoded value anymore, but the value might not be what the host send, so we should keep that.
In fact we might want to add the value in here, so when you change your setting the ones of the room also change?
There was a problem hiding this comment.
In fact we might want to add the value in here, so when you change your setting the ones of the room also change?
I think we should do this? Otherwise remote capabilities are not refreshed, when you change your typing privacy?
There was a problem hiding this comment.
ah, sorry, I misunderstood! Lemme check how to do this
There was a problem hiding this comment.
Done. Alright like this?
Signed-off-by: Anna Larch <anna@nextcloud.com>
miaulalala
force-pushed
the
feat/federated-typing-indicators
branch
from
edec72e to
3c8978a
Compare
nickvergessen
added
enhancement
feature: chat 💬
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
🛠️ API Checklist
🚧 Tasks
🏁 Checklist
docs/has been updated or is not required