Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Edit bot messages in 1:1 conversations #4761

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Edit bot messages in 1:1 conversations #4761

wants to merge 2 commits into from
+17 −6

Conversation

sowjanyakch
Copy link
Contributor

@sowjanyakch sowjanyakch commented Feb 24, 2025 •
edited
Loading

Resolve #4708

  • Edit bot messages in 1-1 conversations.
  • Don't edit messages after 24 hours.

edit_bot_messages

🚧 TODO

  • ...

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔖 Capability is checked or not needed
  • 🔙 Backport requests are created or not needed: /backport to stable-xx.x
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

@sowjanyakch
edit bot messages
e2ca2db 
Signed-off-by: sowjanyakch <sowjanya.kch@gmail.com>
@sowjanyakch
layout changes
0246d2f 
Signed-off-by: sowjanyakch <sowjanya.kch@gmail.com>
@sowjanyakch sowjanyakch marked this pull request as ready for review February 24, 2025 12:43
@sowjanyakch sowjanyakch self-assigned this Feb 24, 2025
@sowjanyakch sowjanyakch added the 3. to review Waiting for reviews label Feb 24, 2025
@github-actions GitHub Actions
Copy link
Contributor

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/4761-talk.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud Talk app.

@github-actions GitHub Actions
Copy link
Contributor

Codacy

Lint

TypemasterPR
Warnings104104
Errors99

SpotBugs

CategoryBaseNew
Bad practice66
Correctness222222
Dodgy code7171
Internationalization33
Malicious code vulnerability33
Performance44
Security11
Total310310

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rapterjet2004 rapterjet2004 Awaiting requested review from rapterjet2004

@mahibi mahibi Awaiting requested review from mahibi

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

At least 1 approving review is required to merge this pull request.

Assignees

@sowjanyakch sowjanyakch

Labels
3. to review Waiting for reviews
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow editing of bot messages in one-to-one
1 participant
@sowjanyakch