-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix multiref mapping #1106
Fix multiref mapping #1106
Conversation
Warning Newer version of the nf-core template is available. Your pipeline is using an old version of the nf-core template: 3.1.2. For more documentation on how to update your pipeline, please see the nf-core documentation and Synchronisation documentation. |
|
Combining input channels only once
50ab83b
to
81e213c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code wise-this LGTM. Might be worth running some tests with the different mappers and multiref to ensure it works as intended for all of them.
This should fix the failure of
test_multiref
with most mappers (e.g.bwamem
).(Sharded) read input channels were
combine
d with references, but for most mappers they were combined a second time later, resulting in duplicates. I hope this changes are valid and I'm not missing anything!