Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added parameter tama_merge_all #44

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

Added parameter tama_merge_all #44

wants to merge 2 commits into from

Conversation

GallVp
Copy link
Member

@GallVp GallVp commented Jan 15, 2025

PR checklist

  • Added parameter tama_merge_all to allow merging of sample-wise beds into a single annotation bed
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/isoseq branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@GallVp GallVp requested a review from sguizard January 15, 2025 22:23
@github-actions GitHub Actions
Copy link

nf-core pipelines lint overall result: Passed ✅ ⚠️

Posted for pipeline commit ff0e5ca

+| ✅ 192 tests passed       |+
#| ❔   1 tests were ignored |#
!| ❗   4 tests had warnings |!

❗ Test warnings:

  • pipeline_todos - TODO string in methods_description_template.yml: #Update the HTML below to your preferred methods description, e.g. add publication citation for this pipeline
  • pipeline_todos - TODO string in main.nf: Optionally add in-text citation tools to this list.
  • pipeline_todos - TODO string in main.nf: Optionally add bibliographic entries to this list.
  • pipeline_todos - TODO string in main.nf: Only uncomment below if logic in toolCitationText/toolBibliographyText has been filled!

❔ Tests ignored:

  • files_unchanged - Required pipeline config not found - {'manifest.author'}

✅ Tests passed:

Run details

  • nf-core/tools version 3.1.1
  • Run at 2025-01-15 22:24:18

@GallVp
Copy link
Member Author

GallVp commented Jan 16, 2025

Once again thank you @sguizard

This one enables merging of all sample-wise annotations into a single annotation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sguizard sguizard Awaiting requested review from sguizard

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@GallVp