-
Notifications
You must be signed in to change notification settings - Fork 31
Periodically re-reconcile boundendpoints and refactor connectivity check #628
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
883a2b9
to
6a0d676
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #628 +/- ##
=======================================
Coverage 28.77% 28.78%
=======================================
Files 95 95
Lines 15706 15705 -1
=======================================
Hits 4520 4520
+ Misses 10922 10921 -1
Partials 264 264 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
6a0d676
to
a518b99
Compare
Reconciling after 10 minutes:
|
jonstacks
approved these changes
Apr 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
tryToBindEndpoint
didn't have a cancellation mechanism so we add that, and then make sure that check runs fairly frequently (every 10 minutes) so the status on endpoints is more up to date.How
Re-queues bound endpoints every 10 minutes and refactors
tryToBindEndpoint
into a connectivity check and separate status update.Breaking Changes
Shouldn't be!