Merge pull request fyne-io#5188 from andydotxyz/release/v2.5.2

Proposed v2.5.2 release

Author: andydotxyz

.github/workflows/license_check.yml

@@ -10,9 +10,9 @@ jobs:
     - uses: actions/checkout@v4
       with:
         persist-credentials: false
-    - uses: WillAbides/setup-go-faster@v1.13.0
+    - uses: WillAbides/setup-go-faster@v1
       with:      
-        go-version: '1.21.x'
+        go-version: '1.23.x'
 
     - name: Install lian
       run: go install lucor.dev/lian@latest

.github/workflows/mobile_tests.yml

@@ -9,13 +9,13 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        go-version: ['1.19.x', '1.21.x']
+        go-version: ['1.19.x', '1.23.x']
 
     steps:
     - uses: actions/checkout@v4
       with:
         persist-credentials: false
-    - uses: WillAbides/setup-go-faster@v1.13.0
+    - uses: WillAbides/setup-go-faster@v1
       with:
         go-version: ${{ matrix.go-version }}
 

.github/workflows/platform_tests.yml

@@ -9,7 +9,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        go-version: ['1.19.x', '1.21.x']
+        go-version: ['1.19.x', '1.23.x']
         os: [ubuntu-latest, macos-latest]
         include:
           - os: ubuntu-latest
@@ -21,7 +21,7 @@ jobs:
     - uses: actions/checkout@v4
       with:
         persist-credentials: false
-    - uses: WillAbides/setup-go-faster@v1.13.0
+    - uses: WillAbides/setup-go-faster@v1
       with:
         go-version: ${{ matrix.go-version }}
 
@@ -51,12 +51,12 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        go-version: ['1.20.x', '1.21.x']
+        go-version: ['1.20.x', '1.22.x']
     steps:
       - uses: actions/checkout@v4
         with:
           persist-credentials: false
-      - uses: WillAbides/setup-go-faster@v1.13.0
+      - uses: WillAbides/setup-go-faster@v1
         with:
           go-version: ${{ matrix.go-version }}
 

.github/workflows/static_analysis.yml

@@ -13,9 +13,9 @@ jobs:
     - uses: actions/checkout@v4
       with:
         persist-credentials: false
-    - uses: WillAbides/setup-go-faster@v1.13.0
+    - uses: WillAbides/setup-go-faster@v1
       with:
-        go-version: '1.21.x'
+        go-version: '1.23.x'
 
     - name: Get dependencies
       run: >-
@@ -33,7 +33,7 @@ jobs:
       run: |
         go install golang.org/x/tools/cmd/goimports@latest
         go install github.com/fzipp/gocyclo/cmd/gocyclo@latest
-        go install honnef.co/go/tools/cmd/staticcheck@v0.4.6
+        go install honnef.co/go/tools/cmd/staticcheck@v0.5.1
         go install github.com/mattn/goveralls@latest
 
     - name: Vet

.github/workflows/web_tests.yml

@@ -13,7 +13,7 @@ jobs:
     - uses: actions/checkout@v4
       with:
         persist-credentials: false
-    - uses: WillAbides/setup-go-faster@v1.13.0
+    - uses: WillAbides/setup-go-faster@v1
       with:
         go-version: '1.19.x'
 

CHANGELOG.md

@@ -3,6 +3,28 @@
 This file lists the main changes with each version of the Fyne toolkit.
 More detailed release notes can be found on the [releases page](https://github.com/fyne-io/fyne/releases). 
 
+## 2.5.2 - 14 October 2024
+
+### Fixed
+
+* Sometimes fyne fails to setup dark mode on Windows (#4758)
+* Memory leak in fontMetrics cache on desktop driver (#4010)
+* Fix possible crash with badly formatted json translation
+* Tree widget doesn't display higher elements until a user selects one (#5095, #4346)
+* Update to the latest breaking API changes in go-text
+* Fix wrapping / truncation of multi-font text runs (#4998)
+* Test window title is not always set (#5116)
+* Deadlock in Button CreateRenderer() (#5114)
+* Fix possible crash in theme watching for windows
+* Fix issue with Movies folder on darwin file dialog
+* widget.Entry: validate when pasting from clipboard (#5058, #5028)
+* Reduce contention in some widget locks
+* Add Swedish translation
+* Improvements to documentation
+* Improved temp check for windows/msys
+* Fix split in a theme override container
+
+
 ## 2.5.1 - 24 August 2024
 
 ### Fixed

animation.go

@@ -45,7 +45,7 @@ type Animation struct {
 }
 
 // NewAnimation creates a very basic animation where the callback function will be called for every
-// rendered frame between time.Now() and the specified duration. The callback values start at 0.0 and
+// rendered frame between [time.Now] and the specified duration. The callback values start at 0.0 and
 // will be 1.0 when the animation completes.
 //
 // Since: 2.0

app.go

@@ -7,9 +7,9 @@ import (
 
 // An App is the definition of a graphical application.
 // Apps can have multiple windows, by default they will exit when all windows
-// have been closed. This can be modified using SetMaster() or SetCloseIntercept().
-// To start an application you need to call Run() somewhere in your main() function.
-// Alternatively use the window.ShowAndRun() function for your main window.
+// have been closed. This can be modified using SetMaster or SetCloseIntercept.
+// To start an application you need to call Run somewhere in your main function.
+// Alternatively use the [fyne.io/fyne/v2.Window.ShowAndRun] function for your main window.
 type App interface {
 	// Create a new window for the application.
 	// The first window to open is considered the "master" and when closed
@@ -27,7 +27,7 @@ type App interface {
 	// SetIcon sets the icon resource used for this application instance.
 	SetIcon(Resource)
 
-	// Run the application - this starts the event loop and waits until Quit()
+	// Run the application - this starts the event loop and waits until [App.Quit]
 	// is called or the last window closes.
 	// This should be called near the end of a main() function as it will block.
 	Run()
@@ -43,7 +43,7 @@ type App interface {
 	Driver() Driver
 
 	// UniqueID returns the application unique identifier, if set.
-	// This must be set for use of the Preferences() functions... see NewWithId(string)
+	// This must be set for use of the [App.Preferences]. see [NewWithID].
 	UniqueID() string
 
 	// SendNotification sends a system notification that will be displayed in the operating system's notification area.
@@ -75,7 +75,7 @@ type App interface {
 	CloudProvider() CloudProvider // get the (if any) configured provider
 
 	// SetCloudProvider allows developers to specify how this application should integrate with cloud services.
-	// See `fyne.io/cloud` package for implementation details.
+	// See [fyne.io/cloud] package for implementation details.
 	//
 	// Since: 2.3
 	SetCloudProvider(CloudProvider) // configure cloud for this app

app/app_desktop_darwin.go

@@ -53,6 +53,6 @@ func themeChanged() {
 	fyne.CurrentApp().Settings().(*settings).setupTheme()
 }
 
-func watchTheme() {
+func watchTheme(_ *settings) {
 	C.watchTheme()
 }

app/app_goxjs.go

@@ -61,7 +61,7 @@ var themeChanged = js.FuncOf(func(this js.Value, args []js.Value) interface{} {
 	return nil
 })
 
-func watchTheme() {
+func watchTheme(_ *settings) {
 	js.Global().Call("matchMedia", "(prefers-color-scheme: dark)").Call("addEventListener", "change", themeChanged)
 }
 func stopWatchingTheme() {

app/app_other.go

@@ -23,6 +23,6 @@ func (a *fyneApp) SendNotification(_ *fyne.Notification) {
 	fyne.LogError("Refusing to show notification for unknown operating system", nil)
 }
 
-func watchTheme() {
+func watchTheme(_ *settings) {
 	// no-op
 }

app/app_windows.go

@@ -95,6 +95,7 @@ func runScript(name, script string) {
 		fyne.LogError("Failed to launch windows notify script", err)
 	}
 }
-func watchTheme() {
-	go internalapp.WatchTheme(fyne.CurrentApp().Settings().(*settings).setupTheme)
+
+func watchTheme(s *settings) {
+	go internalapp.WatchTheme(s.setupTheme)
 }

app/app_xdg.go

@@ -119,17 +119,17 @@ func rootConfigDir() string {
 	return filepath.Join(desktopConfig, "fyne")
 }
 
-func watchTheme() {
+func watchTheme(s *settings) {
 	go func() {
 		// Theme lookup hangs on some desktops. Update theme variant cache from within goroutine.
 		internalapp.CurrentVariant.Store(uint64(findFreedesktopColorScheme()))
-		fyne.CurrentApp().Settings().(*settings).setupTheme()
+		s.setupTheme()
 
 		portalSettings.OnSignalSettingChanged(func(changed portalSettings.Changed) {
 			if changed.Namespace == "org.freedesktop.appearance" && changed.Key == "color-scheme" {
 				themeVariant := colorSchemeToThemeVariant(appearance.ColorScheme(changed.Value.(uint32)))
 				internalapp.CurrentVariant.Store(uint64(themeVariant))
-				fyne.CurrentApp().Settings().(*settings).setupTheme()
+				s.setupTheme()
 			}
 		})
 	}()

app/meta_development.go

@@ -55,7 +55,7 @@ func getProjectPath() string {
 	}
 
 	temp := os.TempDir()
-	if strings.Contains(exe, temp) { // this happens with "go run"
+	if strings.Contains(exe, temp) || strings.Contains(exe, "go-build") { // this happens with "go run"
 		return work
 	}
 

app/settings_desktop.go

@@ -62,7 +62,10 @@ func watchFile(path string, callback func()) *fsnotify.Watcher {
 func (s *settings) watchSettings() {
 	s.watcher = watchFile(s.schema.StoragePath(), s.fileChanged)
 
-	watchTheme()
+	a := fyne.CurrentApp()
+	if a != nil && s != nil && a.Settings() == s { // ignore if testing
+		watchTheme(s)
+	}
 }
 
 func (s *settings) stopWatching() {

app/settings_goxjs.go

@@ -17,7 +17,7 @@ func watchFile(path string, callback func()) {
 }
 
 func (s *settings) watchSettings() {
-	watchTheme()
+	watchTheme(s)
 }
 
 func (s *settings) stopWatching() {

canvas.go

@@ -2,7 +2,7 @@ package fyne
 
 import "image"
 
-// Canvas defines a graphical canvas to which a CanvasObject or Container can be added.
+// Canvas defines a graphical canvas to which a [CanvasObject] or Container can be added.
 // Each canvas has a scale which is automatically applied during the render process.
 type Canvas interface {
 	Content() CanvasObject
@@ -31,7 +31,7 @@ type Canvas interface {
 	// Size returns the current size of this canvas
 	Size() Size
 	// Scale returns the current scale (multiplication factor) this canvas uses to render
-	// The pixel size of a CanvasObject can be found by multiplying by this value.
+	// The pixel size of a [CanvasObject] can be found by multiplying by this value.
 	Scale() float32
 
 	// Overlays returns the overlay stack.

canvasobject.go

@@ -36,27 +36,27 @@ type CanvasObject interface {
 	Refresh()
 }
 
-// Disableable describes any CanvasObject that can be disabled.
+// Disableable describes any [CanvasObject] that can be disabled.
 // This is primarily used with objects that also implement the Tappable interface.
 type Disableable interface {
 	Enable()
 	Disable()
 	Disabled() bool
 }
 
-// DoubleTappable describes any CanvasObject that can also be double tapped.
+// DoubleTappable describes any [CanvasObject] that can also be double tapped.
 type DoubleTappable interface {
 	DoubleTapped(*PointEvent)
 }
 
-// Draggable indicates that a CanvasObject can be dragged.
+// Draggable indicates that a [CanvasObject] can be dragged.
 // This is used for any item that the user has indicated should be moved across the screen.
 type Draggable interface {
 	Dragged(*DragEvent)
 	DragEnd()
 }
 
-// Focusable describes any CanvasObject that can respond to being focused.
+// Focusable describes any [CanvasObject] that can respond to being focused.
 // It will receive the FocusGained and FocusLost events appropriately.
 // When focused it will also have TypedRune called as text is input and
 // TypedKey called when other keys are pressed.
@@ -75,18 +75,18 @@ type Focusable interface {
 	TypedKey(*KeyEvent)
 }
 
-// Scrollable describes any CanvasObject that can also be scrolled.
+// Scrollable describes any [CanvasObject] that can also be scrolled.
 // This is mostly used to implement the widget.ScrollContainer.
 type Scrollable interface {
 	Scrolled(*ScrollEvent)
 }
 
-// SecondaryTappable describes a CanvasObject that can be right-clicked or long-tapped.
+// SecondaryTappable describes a [CanvasObject] that can be right-clicked or long-tapped.
 type SecondaryTappable interface {
 	TappedSecondary(*PointEvent)
 }
 
-// Shortcutable describes any CanvasObject that can respond to shortcut commands (quit, cut, copy, and paste).
+// Shortcutable describes any [CanvasObject] that can respond to shortcut commands (quit, cut, copy, and paste).
 type Shortcutable interface {
 	TypedShortcut(Shortcut)
 }
@@ -95,12 +95,12 @@ type Shortcutable interface {
 //
 // Since: 2.1
 type Tabbable interface {
-	// AcceptsTab() is a hook called by the key press handling logic.
+	// AcceptsTab is a hook called by the key press handling logic.
 	// If it returns true then the Tab key events will be sent using TypedKey.
 	AcceptsTab() bool
 }
 
-// Tappable describes any CanvasObject that can also be tapped.
+// Tappable describes any [CanvasObject] that can also be tapped.
 // This should be implemented by buttons etc that wish to handle pointer interactions.
 type Tappable interface {
 	Tapped(*PointEvent)

cloud.go

@@ -1,7 +1,7 @@
 package fyne
 
 // CloudProvider specifies the identifying information of a cloud provider.
-// This information is mostly used by the `fyne.io/cloud ShowSettings' user flow.
+// This information is mostly used by the [fyne.io/cloud.ShowSettings] user flow.
 //
 // Since: 2.3
 type CloudProvider interface {

cmd/fyne/internal/mobile/binres/binres_test.go

@@ -8,6 +8,7 @@ import (
 	"bytes"
 	"encoding"
 	"encoding/xml"
+	"errors"
 	"fmt"
 	"math"
 	"os"
@@ -246,7 +247,7 @@ func compareElements(have, want *XML) error {
 		}
 	}
 	if buf.Len() > 0 {
-		return fmt.Errorf(buf.String())
+		return errors.New(buf.String())
 	}
 	return nil
 }