Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

banner raises errors #1

Closed
flying-sheep opened this issue Sep 11, 2014 · 1 comment
Closed

banner raises errors #1

flying-sheep opened this issue Sep 11, 2014 · 1 comment

Comments

@flying-sheep
Copy link

when doing

aiomanhole.start_manhole(namespace={'server': something}, path='/var/tmp/testing.manhole')

this is raised:

ERROR:asyncio:Exception in callback <bound method StreamReaderProtocol.connection_made of <asyncio.streams.StreamReaderProtocol object at 0x7fadbb4c4ef0>>(<asyncio.selector_events._SelectorSocketTransport object at 0x7fadbb4c4cc0>,)
handle: Handle(<bound method StreamReaderProtocol.connection_made of <asyncio.streams.StreamReaderProtocol object at 0x7fadbb4c4ef0>>, (<asyncio.selector_events._SelectorSocketTransport object at 0x7fadbb4c4cc0>,))
Traceback (most recent call last):
  File "/usr/lib/python3.4/asyncio/events.py", line 39, in _run
    self._callback(*self._args)
  File "/usr/lib/python3.4/asyncio/streams.py", line 212, in connection_made
    self._stream_writer)
  File "/usr/lib/python3.4/site-packages/aiomanhole/__init__.py", line 211, in __call__
    **self.kwargs
  File "/usr/lib/python3.4/site-packages/aiomanhole/__init__.py", line 50, in __init__
    self.banner = banner if isinstance(banner, bytes) else banner.encode('utf8')
AttributeError: 'NoneType' object has no attribute 'encode'
@nhoad nhoad closed this as completed in 276a23b Sep 14, 2014
@nhoad
Copy link
Owner

nhoad commented Sep 14, 2014

Thanks for the report! This is fixed in 0.2.1, available on PyPI now :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants