Pass loop to ensure_future when starting a unix domain socket. #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nathan-hoad aiomanhole has been great for us other than this bug. Any update on this PR? Would love to see this merged, we're running my branch on canary servers for now. |
|
I'm so sorry I missed this!! I'll merge it and do a release now. |
|
I've pushed out 0.6.0 with this fix and the fix for #4. Again, I'm very sorry I dropped the ball here! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a small bug where starting a server on a unix domain socket uses the global loop.
Adds test coverage for start_server, and changes the test coverage to remove the global loop.
In support of the test coverage, adds the ability to bind to port 0.