Add card footer link & secondary card link #238
Conversation
davidhunter08
added
enhancement
|
I've added styling for secondary card links and added examples to the guidance: 
cc: @Graham-Pembrey |
davidhunter08
force-pushed
the
card-footer-link
branch
from
014aef9 to
5ab4fbb
Compare
| @@ -44,14 +48,23 @@ | |||
| ariaHidden: params.badgeLarge.ariaHidden | |||
| }) }} | |||
| {% endif %} | |||
| {%- if not params.readOnly -%} | |||
| {%- if params.readOnly or params.footer.href -%} | |||
There was a problem hiding this comment.
The formatting might have gone weird here but I can't see what this if statement is doing? From the looks of it, it is doing if (nothing) else (chevron)?
There was a problem hiding this comment.
That is what it is doing if (nothing) else (chevron), maybe I've galaxy brained it and there's a simpler way to do it? It basically needs to hide the chevron if the card id read only or the footer is a link.
There was a problem hiding this comment.
Would it be better to have a params to hide the chevron, eg: chevronHidden: true ?
| @@ -20,10 +20,14 @@ | |||
| {{ params.aboveContent.html | safe }} | |||
| </div> | |||
| {%- endif -%} | |||
| {%- if params.readOnly -%} | |||
| <p class="nhsapp-card__title">{{ params.title }}</p> | |||
| {%- if params.readOnly or params.footer.href -%} | |||
There was a problem hiding this comment.
Again Github could of messed up formatting but why checking for footer.href here?
There was a problem hiding this comment.
It's for if read only or a footer link (have no anchor tag) else (have anchor tag) - maybe there's a better way to achieve this?
|
The guidance looks good @davidhunter08. I'm in two minds about whether "on hub pages" is needed. On the one hand, we've only currently validated and approved of secondary card links being used on a hub page (the new account area). On the other, teams have been exploring potentially using them on error pages, and in the organ donation journey. They might have wider use? I also wonder if we should specify what we mean by 'less important topics'. Maybe:
|
davidhunter08
changed the title
Description
Notes
On this PR, should we also add the: