-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add sub-palette file for Client Generator wrapper VI and Update Generator build spec #633
feat: Add sub-palette file for Client Generator wrapper VI and Update Generator build spec #633
Conversation
@varshini-senthil |
Yes @Prem-MysteryPro, I have raised the changes as a separate PR. |
In the testing I hope we covered the scenario of installing the service package alone and made sure that plugins are working, and service-related palette are loading appropriately. Similarly, what will happen if I install older version of service package already and install latest version of generator package. |
Yes, I tried with certain combinations of installation of the Service and Generator packages to see how the palette files will be affected. In the cases you have mentioned where we will install:
|
Source/Build Specs/Install Custom Actions/Post-Install Custom Action - Generator.vi
Outdated
Show resolved
Hide resolved
Then I think we might need to update the service dependency version to be latest. Related comment. |
Source/Build Specs/Install Custom Actions/Post-Install Custom Action - Generator.vi
Outdated
Show resolved
Hide resolved
Source/Build Specs/Install Custom Actions/Pre-Uninstall Custom Action - Generator.vi
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Waiting to see next round of changes before approving.
I have updated the approach for deploying the Generator package menu files to follow the method used by the Service package. In this approach, the menu files are single-sourced before the package build through a custom pre-build action and then deployed to the respective location during installation. As part of this change, I have made the following updates:
Note: This change in approach is to avoid the programmatic creation of the _Measurement Plug-In SDK folder and the copying of the palette files as post-install actions. This was necessary because, in some cases, the |
What does this Pull Request accomplish?
Client Generator.mnu
to theNI Measurement V2 Client Generator Runtime.lvlib
library. This sub-palette file will hold theGenerate Client.vi
wrapper VIMeasurement Plug-In SDK.mnu
to create a place holder for the new sub-palette file.NI Measurement V2 Client Generator Runtime.lvlib
library to set theClient Generator.mnu
file as the default palette file for the library.Measurement Plug-In SDK Generator
build spec. These action VIs are essential for the deployment of theClient Generator.mnu
sub-palette menu file in the expected location.Measurement Plug-In SDK Generator.vipb
to align with latest changes made to the source code.Why should this Pull Request be merged?
Measurement Plug-In SDK.mnu
file.Measurement Plug-In SDK Generator.vipb
to align with latest changes made to the source code and to add the custom action VIs required for the Generator package build.What testing has been done?
Built the Service and Generator package with the changes and tested the packages to ensure the palette files are deployed and work as expected.