[minor] Update Package and Package dependencies version in Build Spec #638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
varshini-senthil
requested review from
dixonjoel,
aepete,
jasonmreding and
DavidCurtiss
as code owners
| @@ -17,8 +17,8 @@ | |||
| </Library_General_Settings> | |||
| <Advanced_Settings> | |||
| <Package_Dependencies> | |||
| <Additional_External_Dependencies>ni_lib_labview_grpc_library >=1.0.1.1</Additional_External_Dependencies> | |||
| <Additional_External_Dependencies>ni_lib_labview_grpc_servicer >=1.0.1.1</Additional_External_Dependencies> | |||
| <Additional_External_Dependencies>ni_lib_labview_grpc_library >=1.2.7.1</Additional_External_Dependencies> | |||
There was a problem hiding this comment.
Is there a reason you upgraded these minimum versions for grpc-labview? Is there some feature or bug fix that is only present in this version? If so, this is probably the right thing to do. Otherwise, it might limit options for the end user to work around bugs introduced in newer versions of the package that aren't present in older versions of the package.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
Measurement Plug-In SDK ServiceandMeasurement Plug-In SDK Generatorpackages to 3.3.0.1.Context:
Refer to the discussion in this comment #633 (comment)
Why should this Pull Request be merged?
To update the package version and package dependencies version of
Measurement Plug-In SDK ServiceandMeasurement Plug-In SDK Generatorpackages.What testing has been done?
Built both the Service and Generator packages with the changes and verified that the latest version of the package dependencies is listed as auto-dependency during installation.