Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Horizontal Scroll Issue #181

Open
mass2527 opened this issue Sep 5, 2022 · 3 comments
Open

Horizontal Scroll Issue #181

mass2527 opened this issue Sep 5, 2022 · 3 comments

Comments

@mass2527
Copy link
Contributor

mass2527 commented Sep 5, 2022

#179

Hello Mr. Keller,

I really appreciate your reply.
However, I think we are not on the same page.

To be more specific with my issue,
When there are a lot of columns on the sheet, a horizontal scroll appears and it always comes with a vertical scroll as a default, even when it is unnecessary. Thus, that causes the problem, even though when I already assigned the innerHeight instead of the outerHeight.

FYI: My height calculation

<DataSheetGrid
  columns={config.columns}
  value={value}
  height={window.screen.availHeight / 2}
/>

Thanks a lot,
Philly

@kelbyers
Copy link

kelbyers commented Dec 8, 2022

I have this same issue. I am setting the height of the DataSheetGrid to use up all of the available space on the browser page. If I have a grid with a single row of data, and that data fits in the width of the browser page, it looks fine. If I add an additional column that causes the grid to be wider than the window, then the grid will be displayed with the horizontal scrollbar added, but the grid with the scrollbar takes up exactly the same space as the grid without the scrollbar. This results in space for the actual data not being enough to display the entire height of the row. I can scroll vertically, but it is not possible to see an entire row at once.

The issue is not the height property. In the screenshot here, the height is set to 533, and you can see that there is plenty of space available, but the horizontal scrollbar is covering up part of the data.

image

Here is the same row, with the last column removed:

image

@nick-keller
Copy link
Owner

Thanks for the report. I don't have much time at the moment so feel free to send a PR.
I am in the process of re-writing the virtualisation myself, which should solve a few issues and allow for more performance and more flexible API. But the ETA on this is very uncertain :/

@JuanFLZ
Copy link

JuanFLZ commented Jul 26, 2024

2024 and the horizontal scroll is still over last row...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants