Skip to content

Commit

Permalink
try 443
Browse files Browse the repository at this point in the history
  • Loading branch information
whichwit committed Jan 30, 2025
1 parent c10891d commit 6747fec
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 3 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/utility-deploy.yml
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ jobs:
containerAppName: utility
resourceGroup: ${{ vars.ACA_RESOURCE_GROUP }}
containerAppEnvironment: ${{ vars.ACA_APP_ENVIRONMENT }}
targetPort: 80
targetPort: 443
disableTelemetry: true
- name: Update revision
uses: azure/CLI@v2
Expand Down
1 change: 1 addition & 0 deletions projects/VitalRecord.Utility/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ RUN npm run build

# Expose port 8080
EXPOSE 80
EXPOSE 443

# Start the app
CMD npm run start

Check warning on line 23 in projects/VitalRecord.Utility/Dockerfile

View workflow job for this annotation

GitHub Actions / build-and-push-image

JSON arguments recommended for ENTRYPOINT/CMD to prevent unintended behavior related to OS signals

JSONArgsRecommended: JSON arguments recommended for CMD to prevent unintended behavior related to OS signals More info: https://docs.docker.com/go/dockerfile/rule/json-args-recommended/
2 changes: 1 addition & 1 deletion projects/VitalRecord.Utility/dist/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ var __importDefault = (this && this.__importDefault) || function (mod) {
Object.defineProperty(exports, "__esModule", { value: true });
const express_1 = __importDefault(require("express"));
const app = (0, express_1.default)();
const port = 80;
const port = 443;
app.get('/', (req, res) => {
res.send('Hello from Express with TypeScript!');
});
Expand Down
2 changes: 1 addition & 1 deletion projects/VitalRecord.Utility/src/index.ts
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import express, { Request, Response } from 'express';

const app = express();
const port = 80;
const port = 443;

app.get('/', (req: Request, res: Response) => {
res.send('Hello from Express with TypeScript!');
Expand Down

0 comments on commit 6747fec

Please sign in to comment.