feat(canary): better error handling (#204)

projects/Canary/ClientApp/src/error.js

@@ -1,11 +1,12 @@
 import { toast } from 'react-semantic-toasts';
 
 export function connectionErrorToast(error) {
-  toast({
-    type: 'error',
-    icon: 'exclamation circle',
-    title: 'Error!',
-    description: 'There was an error communicating with Canary. The error was: "' + error + '"',
-    time: 5000,
-  });
+    let errMsg = error?.response?.data?.errorDetails ?? error?.response ?? error
+    toast({
+        type: 'error',
+        icon: 'exclamation circle',
+        title: 'Error!',
+        description: 'Error: "' + errMsg + '"',
+        time: 10000,
+    });
 }

projects/Canary/Filter/ExceptionHandlingFilter.cs

@@ -0,0 +1,26 @@
+using Microsoft.AspNetCore.Mvc.Filters;
+using Microsoft.AspNetCore.Mvc;
+using System;
+
+namespace canary.Filter
+{
+    public class ExceptionHandlingFilter : IExceptionFilter
+    {
+        public void OnException(ExceptionContext context)
+        {
+            var exception = context.Exception;
+
+            var errorResponse = new
+            {
+                ErrorDetails = exception.Message
+            };
+
+            context.Result = new JsonResult(errorResponse)
+            {
+                StatusCode = 500
+            };
+
+            context.ExceptionHandled = true;
+        }
+    }
+}

projects/Canary/Startup.cs

@@ -11,6 +11,7 @@
 using System.Linq;
 using System.Diagnostics;
 using System.Runtime.InteropServices;
+using canary.Filter;
 
 namespace canary
 {
@@ -41,7 +42,10 @@ public void ConfigureServices(IServiceCollection services)
                 options.SuppressModelStateInvalidFilter = true;
             });
 
-            services.AddControllers().AddNewtonsoftJson();
+            services.AddControllers(options => 
+            { 
+                options.Filters.Add<ExceptionHandlingFilter>(); 
+            }).AddNewtonsoftJson();
 
             services.AddCors();