Gets the nimsuggest path from nimble when nimble has nimdir (#200)

* Gets the nimsuggest path from `nimble` when `nimble` has `nimdir`

This depends on nim-lang/nimble#1221
It also needs to be tested in Win.

While developing this found an issue with the project discovery, it uses `nim dump` but it doesnt seem to end when Nim is a local dep, it takes too long. Will try to speed it up in the nimble side of things

* Win works

* Adds Nim version to the notification so the user knows what version is used

* uses nimble dump for nimdir

Author: jmgomez

nimlangserver.nim

@@ -665,12 +665,41 @@ proc getWorkingDir(ls: LanguageServer, path: string): Future[string] {.async.} =
       result = rootPath.string / m.directory
       break;
 
+proc getNimVersion(nimDir: string): string =
+  let cmd = 
+    if nimDir == "": "nim --version"
+    else: nimDir / "nim --version"
+  let info = execProcess(cmd)
+  const NimCompilerVersion = "Nim Compiler Version "
+  for line in info.splitLines:
+    if line.startsWith(NimCompilerVersion):
+      return line
+
+proc getNimSuggestPath(ls: LanguageServer, conf: NlsConfig, workingDir: string): string =
+  #Attempting to see if the project is using a custom Nim version, if it's the case this will be slower than usual
+  let info: string = execProcess("nimble dump ", workingDir)
+  var nimDir = ""
+  const NimDirSplit = "nimDir:"
+  for line in info.splitLines:
+    if line.startsWith(NimDirSplit):
+        nimDir = line.split(NimDirSplit)[1].strip.strip(chars = {'"', ' '})
+      
+  result = expandTilde(conf.nimsuggestPath.get("")) 
+  var nimVersion = ""
+  if result == "":
+    if nimDir != "" and nimDir.dirExists:
+      nimVersion = getNimVersion(nimDir) & " from " & nimDir
+      result = nimDir / "nimsuggest"      
+    else:
+      nimVersion = getNimVersion("")
+      result = findExe "nimsuggest" 
+  ls.showMessage(fmt "Using {nimVersion}", MessageType.Info)      
 
 proc createOrRestartNimsuggest(ls: LanguageServer, projectFile: string, uri = ""): void {.gcsafe.} =
   let
     configuration = ls.getWorkspaceConfiguration().waitFor()
-    nimsuggestPath = expandTilde(configuration.nimsuggestPath.get("nimsuggest"))
     workingDir = ls.getWorkingDir(projectFile).waitFor()
+    nimsuggestPath = ls.getNimSuggestPath(configuration, workingDir)
     timeout = configuration.timeout.get(REQUEST_TIMEOUT)
     restartCallback = proc (ns: Nimsuggest) {.gcsafe.} =
       warn "Restarting the server due to requests being to slow", projectFile = projectFile

suggestapi.nim

@@ -320,10 +320,9 @@ proc createNimsuggest*(root: string,
     thread: Thread[tuple[pipe: AsyncPipe, process: Process]]
     stderrThread: Thread[tuple[root: string, process: Process]]
     input = pipe.asyncPipeInput
-    fullPath = findExe(nimsuggestPath)
 
-  info "Starting nimsuggest", root = root, timeout = timeout, path = nimsuggestPath,
-    fullPath = fullPath, workingDir = workingDir
+  info "Starting nimsuggest", root = root, timeout = timeout, path = nimsuggestPath, 
+    workingDir = workingDir
 
   result = Nimsuggest()
   result.requestQueue = Deque[SuggestCall]()
@@ -332,7 +331,7 @@ proc createNimsuggest*(root: string,
   result.timeoutCallback = timeoutCallback
   result.errorCallback = errorCallback
 
-  if fullPath != "":
+  if nimsuggestPath != "":
     result.protocolVersion = detectNimsuggestVersion(root, nimsuggestPath, workingDir)
     if result.protocolVersion > HighestSupportedNimSuggestProtocolVersion:
       result.protocolVersion = HighestSupportedNimSuggestProtocolVersion