fix crash on empty file (#217)

* merge

* forgot to add fix back in

Author: Graveflo

ls.nim

@@ -1,20 +1,20 @@
-import macros, strformat, 
+import macros, strformat,
   faststreams/async_backend,
   os, sugar, sequtils, hashes, osproc,
   suggestapi, protocol/enums, protocol/types, with, tables, strutils, sets,
   ./utils, chronicles, std/re, uri, "$nim/compiler/pathutils",
   json_serialization, std/json
 
 
-proc getVersionFromNimble(): string = 
+proc getVersionFromNimble(): string =
   #We should static run nimble dump instead
   const content = staticRead("nimlangserver.nimble")
   for v in content.splitLines:
     if v.startsWith("version"):
       return v.split("=")[^1].strip(chars = {' ', '"'})
   return "unknown"
 
-const 
+const
   RESTART_COMMAND* = "nimlangserver.restart"
   RECOMPILE_COMMAND* = "nimlangserver.recompile"
   CHECK_PROJECT_COMMAND* = "nimlangserver.checkProject"
@@ -103,15 +103,15 @@ type
     Folder,
     Cfg,
     Nimble
-  
+
   NimbleDumpInfo* = object
     srcDir*: string
     name*: string
     nimDir*: Option[string]
     nimblePath*: Option[string]
     entryPoints*: seq[string] #when it's empty, means the nimble version doesnt dump it.
-  
-  OnExitCallback* = proc (): Future[void] {.gcsafe.} #To be called when the server is shutting down 
+
+  OnExitCallback* = proc (): Future[void] {.gcsafe.} #To be called when the server is shutting down
   NotifyAction* = proc (name: string, params: JsonNode) {. gcsafe.} #Send a notification to the client
   CallAction* = proc (name: string, params: JsonNode): Future[JsonNode] {. gcsafe.} #Send a request to the client
 
@@ -162,7 +162,7 @@ func parameterHintsEnabled*(cnf: NlsConfig): bool =
 func inlayHintsEnabled*(cnf: NlsConfig): bool =
   typeHintsEnabled(cnf) or exceptionHintsEnabled(cnf) or parameterHintsEnabled(cnf)
 
-proc supportSignatureHelp*(cc: ClientCapabilities): bool = 
+proc supportSignatureHelp*(cc: ClientCapabilities): bool =
   if cc.isNil: return false
   let caps = cc.textDocument
   caps.isSome and caps.get.signatureHelp.isSome
@@ -182,14 +182,19 @@ proc getNimbleDumpInfo*(ls: LanguageServer, nimbleFile: string): NimbleDumpInfo
       result.nimblePath = some line[(1 + line.find '"')..^2]
     if line.startsWith("entryPoints"):
       result.entryPoints = line[(1 + line.find '"')..^2].split(',').mapIt(it.strip(chars = {' ', '"'}))
-      
+
   var nimbleFile = nimbleFile
   if nimbleFile == "" and result.nimblePath.isSome:
     nimbleFile = result.nimblePath.get
   if nimbleFile != "":
     ls.nimDumpCache[nimbleFile] = result
 
 proc parseWorkspaceConfiguration*(conf: JsonNode): NlsConfig =
+  try:
+    if conf.kind == JObject and conf["settings"].kind == JObject:
+      return conf["settings"]["nim"].to(NlsConfig)
+  except CatchableError:
+    discard
   try:
     let nlsConfig: seq[NlsConfig] = (%conf).to(seq[NlsConfig])
     result = if nlsConfig.len > 0 and nlsConfig[0] != nil: nlsConfig[0] else: NlsConfig()
@@ -200,32 +205,32 @@ proc parseWorkspaceConfiguration*(conf: JsonNode): NlsConfig =
 proc getWorkspaceConfiguration*(ls: LanguageServer): Future[NlsConfig] {.async.} =
   parseWorkspaceConfiguration(ls.workspaceConfiguration.await)
 
-proc showMessage*(ls: LanguageServer, message: string, typ: MessageType) =  
+proc showMessage*(ls: LanguageServer, message: string, typ: MessageType) =
   proc notify() =
     ls.notify(
       "window/showMessage",
       %* {
          "type": typ.int,
-         "message": message 
+         "message": message
       })
-  let verbosity = 
+  let verbosity =
     ls
     .getWorkspaceConfiguration
     .waitFor
     .notificationVerbosity.get(NlsNotificationVerbosity.nvInfo)
   debug "ShowMessage ", message = message
   case verbosity:
-  of nvInfo: 
+  of nvInfo:
     notify()
   of nvWarning:
     if typ.int <= MessageType.Warning.int :
        notify()
   of nvError:
-    if typ == MessageType.Error: 
+    if typ == MessageType.Error:
       notify()
   else: discard
 
-proc getLspStatus*(ls: LanguageServer): NimLangServerStatus = 
+proc getLspStatus*(ls: LanguageServer): NimLangServerStatus =
   result.version = LSPVersion
   for projectFile, futNs in ls.projectFiles:
     let futNs = ls.projectFiles[projectFile]
@@ -237,9 +242,9 @@ proc getLspStatus*(ls: LanguageServer): NimLangServerStatus =
         version: ns.version,
         path: ns.nimsuggestPath,
         port: ns.port,
-      )    
+      )
       result.nimsuggestInstances.add nsStatus
-  
+
   for openFile in ls.openFiles.keys:
     let openFilePath = openFile.uriToPath
     result.openFiles.add openFilePath
@@ -298,7 +303,7 @@ proc inlayHintsConfigurationEquals*(a, b: NlsConfig): bool =
     result = a.inlayHints.isSome == b.inlayHints.isSome
 
 proc getNimVersion(nimDir: string): string =
-  let cmd = 
+  let cmd =
     if nimDir == "": "nim --version"
     else: nimDir / "nim --version"
   let info = execProcess(cmd)
@@ -311,20 +316,20 @@ proc getNimSuggestPathAndVersion(ls: LanguageServer, conf: NlsConfig, workingDir
   #Attempting to see if the project is using a custom Nim version, if it's the case this will be slower than usual
   let nimbleDumpInfo = ls.getNimbleDumpInfo("")
   let nimDir = nimbleDumpInfo.nimDir.get ""
-      
-  var nimsuggestPath = expandTilde(conf.nimsuggestPath.get("")) 
+
+  var nimsuggestPath = expandTilde(conf.nimsuggestPath.get(""))
   var nimVersion = ""
   if nimsuggestPath == "":
     if nimDir != "" and nimDir.dirExists:
       nimVersion = getNimVersion(nimDir) & " from " & nimDir
-      nimsuggestPath = nimDir / "nimsuggest"      
+      nimsuggestPath = nimDir / "nimsuggest"
     else:
       nimVersion = getNimVersion("")
       nimsuggestPath = findExe "nimsuggest"
   else:
     nimVersion = getNimVersion(nimsuggestPath.parentDir)
-  ls.showMessage(fmt "Using {nimVersion}", MessageType.Info)    
-  (nimsuggestPath, nimVersion)  
+  ls.showMessage(fmt "Using {nimVersion}", MessageType.Info)
+  (nimsuggestPath, nimVersion)
 
 proc getProjectFileAutoGuess*(ls: LanguageServer, fileUri: string): string =
   let file = fileUri.decodeUrl
@@ -418,7 +423,7 @@ proc cancelPendingFileChecks*(ls: LanguageServer, nimsuggest: Nimsuggest) =
         cancelFileCheck.complete()
       fileData.needsChecking = false
 
-proc getNimsuggest*(ls: LanguageServer, uri: string): Future[Nimsuggest] {.async, gcsafe.} 
+proc getNimsuggest*(ls: LanguageServer, uri: string): Future[Nimsuggest] {.async, gcsafe.}
 
 proc uriStorageLocation*(ls: LanguageServer, uri: string): string =
   ls.storageDir / (hash(uri).toHex & ".nim")
@@ -661,7 +666,7 @@ proc getProjectFile*(fileUri: string, ls: LanguageServer): Future[string] {.asyn
     rootPath = AbsoluteDir(ls.initializeParams.getRootPath)
     pathRelativeToRoot = string(AbsoluteFile(fileUri).relativeTo(rootPath))
     mappings = ls.getWorkspaceConfiguration.await().projectMapping.get(@[])
-  
+
   for mapping in mappings:
     if find(cstring(pathRelativeToRoot), re(mapping.fileRegex), 0, pathRelativeToRoot.len) != -1:
       result = string(rootPath) / mapping.projectFile
@@ -692,7 +697,7 @@ proc getProjectFile*(fileUri: string, ls: LanguageServer): Future[string] {.asyn
     if ns.canHandleUnknown and not isKnown:
       debug "File is not known by nimsuggest", uri = fileUri, projectFile = result
       result = fileUri
-  
+
   if result == "":
     result = fileUri
 
@@ -722,4 +727,4 @@ proc checkFile*(ls: LanguageServer, uri: string): Future[void] {.async.} =
 
   ls.progress(token, "end")
 
-  ls.sendDiagnostics(diagnostics, path)
+  ls.sendDiagnostics(diagnostics, path)

routes.nim

@@ -1,4 +1,4 @@
-import macros, strformat, 
+import macros, strformat,
   faststreams/async_backend,
   json_rpc/streamconnection, json_rpc/server, os, sugar, sequtils,
   suggestapi, protocol/enums, protocol/types, with, tables, strutils,
@@ -73,7 +73,7 @@ proc initialize*(p: tuple[ls: LanguageServer, onExit: OnExitCallback], params: I
       documentSymbolProvider: some(true),
       codeActionProvider: some(true)
     )
-  )  
+  )
   # Support rename by default, but check if we can also support prepare
   result.capabilities.renameProvider = %true
   if params.capabilities.textDocument.isSome:
@@ -86,7 +86,7 @@ proc initialize*(p: tuple[ls: LanguageServer, onExit: OnExitCallback], params: I
       }
   debug "Initialize completed. Trying to start nimsuggest instances"
   #If we are in a nimble project here, we try to start the entry points
-  
+
 proc toCompletionItem(suggest: Suggest): CompletionItem =
   with suggest:
     return CompletionItem %* {
@@ -115,7 +115,7 @@ proc completion*(ls: LanguageServer, params: CompletionParams, id: int):
       for completion in result:
         if completion.label notin unique:
           unique[completion.label] = completion
-      result = unique.values.toSeq    
+      result = unique.values.toSeq
 
 proc toLocation*(suggest: Suggest): Location =
   return Location %* {
@@ -192,7 +192,7 @@ proc expand*(ls: LanguageServer, params: ExpandTextDocumentPositionParams):
       result = ExpandResult(content: expand[0].doc.fixIdentation(character),
                             range: expand[0].createRangeFromSuggest())
 
-proc status*(ls: LanguageServer, params: NimLangServerStatusParams): Future[NimLangServerStatus] {.async.} = 
+proc status*(ls: LanguageServer, params: NimLangServerStatusParams): Future[NimLangServerStatus] {.async.} =
   debug "Received status request"
   ls.getLspStatus()
 
@@ -468,9 +468,9 @@ proc executeCommand*(ls: LanguageServer, params: ExecuteCommandParams):
           ls.progress(token, "end")
           ls.checkProject(projectFile.pathToUri).traceAsyncErrors
 
-  result = newJNull() 
+  result = newJNull()
 
-proc toSignatureInformation(suggest: Suggest): SignatureInformation = 
+proc toSignatureInformation(suggest: Suggest): SignatureInformation =
   var fnKind, strParams: string
   var params = newSeq[ParameterInformation]()
   #TODO handle params. Ideally they are handled in the compiler but as fallback we could handle them as follows
@@ -490,16 +490,16 @@ proc toSignatureInformation(suggest: Suggest): SignatureInformation =
     "parameters": newSeq[ParameterInformation](), #notice params is not used
     }
 
-proc signatureHelp*(ls: LanguageServer, params: SignatureHelpParams, id: int): 
-  Future[Option[SignatureHelp]] {.async.} = 
+proc signatureHelp*(ls: LanguageServer, params: SignatureHelpParams, id: int):
+  Future[Option[SignatureHelp]] {.async.} =
     #TODO handle prev signature
     # if params.context.activeSignatureHelp.isSome:
     #   let prevSignature = params.context.activeSignatureHelp.get.signatures.get[params.context.activeSignatureHelp.get.activeSignature.get]
     #   debug "prevSignature ", prevSignature = $prevSignature.label
     # else:
     #   debug "no prevSignature"
     #only support signatureHelp if the client supports it
-    # if docCaps.signatureHelp.isSome and docCaps.signatureHelp.get.contextSupport.get(false):    
+    # if docCaps.signatureHelp.isSome and docCaps.signatureHelp.get.contextSupport.get(false):
     #   result.capabilities.signatureHelpProvider = SignatureHelpOptions(
     #           triggerCharacters: some(@["(", ","])
     #   )
@@ -509,11 +509,11 @@ proc signatureHelp*(ls: LanguageServer, params: SignatureHelpParams, id: int):
     with (params.position, params.textDocument):
       let nimsuggest = await ls.getNimsuggest(uri)
       if nsCon notin nimSuggest.capabilities:
-        #support signatureHelp only if the current version of NimSuggest supports it. 
+        #support signatureHelp only if the current version of NimSuggest supports it.
         return none[SignatureHelp]()
 
       let completions = await nimsuggest
-                              .con(uriToPath(uri),                              
+                              .con(uriToPath(uri),
                                   ls.uriToStash(uri),
                                   line + 1,
                                   ls.getCharacter(uri, line, character))
@@ -525,7 +525,7 @@ proc signatureHelp*(ls: LanguageServer, params: SignatureHelpParams, id: int):
           activeSignature: some(0),
           activeParameter: some(0)
         )
-      else: 
+      else:
         return none[SignatureHelp]()
 
 proc workspaceSymbol*(ls: LanguageServer, params: WorkspaceSymbolParams, id: int):
@@ -603,18 +603,21 @@ proc setTrace*(ls: LanguageServer, params: SetTraceParams) {.async.} =
 proc didChange*(ls: LanguageServer, params: DidChangeTextDocumentParams):
     Future[void] {.async, gcsafe.} =
    with params:
-     let
-       uri = textDocument.uri
-       file = open(ls.uriStorageLocation(uri), fmWrite)
+      let
+        uri = textDocument.uri
+        file = open(ls.uriStorageLocation(uri), fmWrite)
 
-     ls.openFiles[uri].fingerTable = @[]
-     ls.openFiles[uri].changed = true
-     for line in contentChanges[0].text.splitLines:
-       ls.openFiles[uri].fingerTable.add line.createUTFMapping()
-       file.writeLine line
-     file.close()
+      ls.openFiles[uri].fingerTable = @[]
+      ls.openFiles[uri].changed = true
+      if contentChanges.len <= 0:
+        file.close()
+        return
+      for line in contentChanges[0].text.splitLines:
+        ls.openFiles[uri].fingerTable.add line.createUTFMapping()
+        file.writeLine line
+      file.close()
 
-     ls.scheduleFileCheck(uri)
+      ls.scheduleFileCheck(uri)
 
 proc didSave*(ls: LanguageServer, params: DidSaveTextDocumentParams):
     Future[void] {.async, gcsafe.} =
@@ -627,7 +630,7 @@ proc didSave*(ls: LanguageServer, params: DidSaveTextDocumentParams):
   if ls.getWorkspaceConfiguration().await().checkOnSave.get(true):
     debug "Checking project", uri = uri
     traceAsyncErrors ls.checkProject(uri)
-  
+
   var toStop = newTable[string, Nimsuggest]()
   #We first get the project file for the current file so we can test if this file recently imported another project
   let thisProjectFile = await getProjectFile(uri.uriToPath, ls)
@@ -636,9 +639,9 @@ proc didSave*(ls: LanguageServer, params: DidSaveTextDocumentParams):
     for projectFile in ls.projectFiles.keys:
       if projectFile in ls.entryPoints: continue
       let isKnown = await ns.isKnown(projectFile)
-      if isKnown: 
+      if isKnown:
         toStop[projectFile] = await ls.projectFiles[projectFile]
-    
+
     for projectFile, ns in toStop:
       ns.stop()
       ls.projectFiles.del projectFile
@@ -683,13 +686,13 @@ proc didOpen*(ls: LanguageServer, params: DidOpenTextDocumentParams):
     ls.getNimsuggest(uri).addCallback() do (fut: Future[Nimsuggest]) -> void:
       if not fut.failed:
         discard ls.warnIfUnknown(fut.read, uri, projectFile)
-      
+
     let projectFileUri = projectFile.pathToUri
     if projectFileUri notin ls.openFiles:
       var params = params
       params.textDocument.uri = projectFileUri
       await didOpen(ls, params)
-      
+
       debug "Opening project file", uri = projectFile, file = uri
 
 proc didChangeConfiguration*(ls: LanguageServer, conf: JsonNode):