From 6b80b0062338c1092422bb8333627a4847044c4b Mon Sep 17 00:00:00 2001 From: jmgomez Date: Wed, 30 Apr 2025 15:04:18 +0100 Subject: [PATCH 1/7] fixes ci --- .github/workflows/binaries.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/binaries.yml b/.github/workflows/binaries.yml index 0686a3b..5be3e02 100644 --- a/.github/workflows/binaries.yml +++ b/.github/workflows/binaries.yml @@ -5,9 +5,9 @@ on: branches: - master paths-ignore: ['media/**', 'docs/**', '**/*.md'] - pull_request: + pull_request: paths-ignore: ['media/**', 'docs/**', '**/*.md'] - workflow_dispatch: + workflow_dispatch: jobs: build: strategy: From 8a16bffd05f99c643c695d5f7acd02cf943b6d56 Mon Sep 17 00:00:00 2001 From: jmgomez Date: Wed, 30 Apr 2025 15:09:48 +0100 Subject: [PATCH 2/7] bumps ubuntu in the binaries ci --- .github/workflows/binaries.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/binaries.yml b/.github/workflows/binaries.yml index 5be3e02..f76212e 100644 --- a/.github/workflows/binaries.yml +++ b/.github/workflows/binaries.yml @@ -66,7 +66,7 @@ jobs: include: - target: os: linux - builder: ubuntu-20.04 + builder: ubuntu-22.04 - target: os: macos builder: macos-14 @@ -81,7 +81,7 @@ jobs: runs-on: ${{ matrix.builder }} steps: - name: Setup Build - if: matrix.builder == 'ubuntu-20.04' + if: matrix.builder == 'ubuntu-22.04' run: | sudo apt install gcc make gcc-aarch64-linux-gnu binutils-aarch64-linux-gnu \ gcc-i686-linux-gnu binutils-i686-linux-gnu \ From 7e68ef0152c1c523c98691394b7e6316df2aa954 Mon Sep 17 00:00:00 2001 From: jmgomez Date: Wed, 30 Apr 2025 15:22:31 +0100 Subject: [PATCH 3/7] Fixes releases action --- .github/workflows/binaries.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/binaries.yml b/.github/workflows/binaries.yml index f76212e..8542dc2 100644 --- a/.github/workflows/binaries.yml +++ b/.github/workflows/binaries.yml @@ -210,6 +210,7 @@ jobs: makeLatest: true prerelease: true tag: latest + token: ${{ secrets.GITHUB_TOKEN }} - name: Delete artefacts uses: geekyeggo/delete-artifact@v5 From df5acd015e6a93821f5bb3bcd7540a233be8f24a Mon Sep 17 00:00:00 2001 From: jmgomez Date: Thu, 1 May 2025 10:52:59 +0100 Subject: [PATCH 4/7] disables github release as there is a permission issue --- .github/workflows/binaries.yml | 52 +++++++++++++++++----------------- 1 file changed, 26 insertions(+), 26 deletions(-) diff --git a/.github/workflows/binaries.yml b/.github/workflows/binaries.yml index 8542dc2..9700727 100644 --- a/.github/workflows/binaries.yml +++ b/.github/workflows/binaries.yml @@ -191,29 +191,29 @@ jobs: name: nimlangserver-macos-universal.zip path: nimlangserver-macos-universal.zip - create-github-release: - name: Create Github Release - needs: [build, create-macos-universal-binary] - runs-on: ubuntu-latest - permissions: - contents: write - actions: write - steps: - - name: Download artefacts - uses: actions/download-artifact@v4 - - - uses: ncipollo/release-action@v1 - with: - name: Latest Nimlangserver Binaries - artifacts: "*/*" - allowUpdates: true - makeLatest: true - prerelease: true - tag: latest - token: ${{ secrets.GITHUB_TOKEN }} - - - name: Delete artefacts - uses: geekyeggo/delete-artifact@v5 - with: - failOnError: false - name: "nimlangserver-*" + # create-github-release: + # name: Create Github Release + # needs: [build, create-macos-universal-binary] + # runs-on: ubuntu-latest + # permissions: + # contents: write + # actions: write + # steps: + # - name: Download artefacts + # uses: actions/download-artifact@v4 + + # - uses: ncipollo/release-action@v1 + # with: + # name: Latest Nimlangserver Binaries + # artifacts: "*/*" + # allowUpdates: true + # makeLatest: true + # prerelease: true + # tag: latest + # token: ${{ secrets.GITHUB_TOKEN }} + + # - name: Delete artefacts + # uses: geekyeggo/delete-artifact@v5 + # with: + # failOnError: false + # name: "nimlangserver-*" From dae41cf59c4c26df4fd789add42eb86bb88af700 Mon Sep 17 00:00:00 2001 From: jmgomez Date: Mon, 5 May 2025 09:57:29 +0100 Subject: [PATCH 5/7] Updates action --- .github/workflows/binaries.yml | 57 ++++++++++++++++++---------------- 1 file changed, 31 insertions(+), 26 deletions(-) diff --git a/.github/workflows/binaries.yml b/.github/workflows/binaries.yml index 9700727..4b7b8c2 100644 --- a/.github/workflows/binaries.yml +++ b/.github/workflows/binaries.yml @@ -191,29 +191,34 @@ jobs: name: nimlangserver-macos-universal.zip path: nimlangserver-macos-universal.zip - # create-github-release: - # name: Create Github Release - # needs: [build, create-macos-universal-binary] - # runs-on: ubuntu-latest - # permissions: - # contents: write - # actions: write - # steps: - # - name: Download artefacts - # uses: actions/download-artifact@v4 - - # - uses: ncipollo/release-action@v1 - # with: - # name: Latest Nimlangserver Binaries - # artifacts: "*/*" - # allowUpdates: true - # makeLatest: true - # prerelease: true - # tag: latest - # token: ${{ secrets.GITHUB_TOKEN }} - - # - name: Delete artefacts - # uses: geekyeggo/delete-artifact@v5 - # with: - # failOnError: false - # name: "nimlangserver-*" + create-github-release: + name: Create Github Release + needs: [build, create-macos-universal-binary] + runs-on: ubuntu-latest + permissions: + contents: write + actions: write + steps: + - name: Download artefacts + uses: actions/download-artifact@v4 + + - name: Get version from tag + id: get_version + run: echo "VERSION=${GITHUB_REF#refs/tags/}" >> $GITHUB_OUTPUT + + - uses: ncipollo/release-action@v1 + with: + name: "Nimlangserver ${{ steps.get_version.outputs.VERSION }}" + artifacts: "*/*" + allowUpdates: true + makeLatest: true + prerelease: false + tag: ${{ steps.get_version.outputs.VERSION }} + token: ${{ secrets.GITHUB_TOKEN }} + generateReleaseNotes: true + + - name: Delete artefacts + uses: geekyeggo/delete-artifact@v5 + with: + failOnError: false + name: "nimlangserver-*" From 89d45630c6b4a23524a3ffd69b55bebe0ffcab2a Mon Sep 17 00:00:00 2001 From: jmgomez Date: Mon, 5 May 2025 10:06:51 +0100 Subject: [PATCH 6/7] Binaries wf update --- .github/workflows/binaries.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/binaries.yml b/.github/workflows/binaries.yml index 4b7b8c2..8e558df 100644 --- a/.github/workflows/binaries.yml +++ b/.github/workflows/binaries.yml @@ -2,8 +2,8 @@ on: push: tags: - 'v*' # "v1.2.3" - branches: - - master + # branches: #Dont push to master the binaries as GH Actions will return an Error 403: Resource not accessible by integration + # - master paths-ignore: ['media/**', 'docs/**', '**/*.md'] pull_request: paths-ignore: ['media/**', 'docs/**', '**/*.md'] From 9c491da77c82f42afbffc788de50b2ba03d64b5f Mon Sep 17 00:00:00 2001 From: jmgomez Date: Mon, 5 May 2025 10:14:16 +0100 Subject: [PATCH 7/7] removes pr --- .github/workflows/binaries.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/binaries.yml b/.github/workflows/binaries.yml index 8e558df..f2979d5 100644 --- a/.github/workflows/binaries.yml +++ b/.github/workflows/binaries.yml @@ -5,8 +5,8 @@ on: # branches: #Dont push to master the binaries as GH Actions will return an Error 403: Resource not accessible by integration # - master paths-ignore: ['media/**', 'docs/**', '**/*.md'] - pull_request: - paths-ignore: ['media/**', 'docs/**', '**/*.md'] + # pull_request: + # paths-ignore: ['media/**', 'docs/**', '**/*.md'] workflow_dispatch: jobs: build: