feat(frontend): Vector base maps #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Migrate from `mapbox-gl` to `maplibre-gl`. - Replace `DeckMap` with `BaseMap`, `and `DeckGLOverlay` for data layers. - Refactor map controls and map view state. - Roll back concurrent rendering, which seems to be causing a null ref error inside React Map GL when it instantiates `mapbox`.
eatyourgreens
commented
May 30, 2024
Comment on lines
+1
to
+5
| import { render } from 'react-dom'; | ||
| import { App } from './App'; | ||
|
|
||
| const container = document.getElementById('root'); | ||
| const root = createRoot(container); | ||
| root.render(<App />); | ||
| render(<App />, container); |
There was a problem hiding this comment.
Rolling back concurrent rendering here is a workaround to avoid visgl/react-map-gl#1960, which crashes the map when it mounts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mapbox-gltomaplibre-gl.DeckMapwithBaseMap, andDeckGLOverlayfor data layers.mapbox(see [Bug] Invalid type: 'container' must be a String or HTMLElement. visgl/react-map-gl#1960.)This is essentially nismod/irv-frontend#28 ported across to this repo.