oh no, having enable condition depend on pkgs is making the overlay inf recurse :( (or atleast I'm pretty sure that's whats happening) @MattSturgeon do you have any advice here?

having enable condition depend on pkgs is making the overlay inf recurse

I don't see where an enable condition depends on pkgs?

having enable condition depend on pkgs is making the overlay inf recurse

I don't see where an enable condition depends on pkgs?

in /modules/gnome/hm.nix

Note that the overlay is only necessary on NixOS: GNOME Shell is not installed by Home Manager, so there is never a need for the overlay to be enabled there. Maybe that makes it easier to avoid the infinite recursion.

having enable condition depend on pkgs is making the overlay inf recurse

I don't see where an enable condition depends on pkgs?

in /modules/gnome/hm.nix

Ah, so the issue is the enable option defaults to config.stylix.autoEnable && pkgs.stdenv.hostPlatform.isLinux, but the same enable option is deciding whether or not pkgs is extended with the overlay.

I'm not convinced that should be inf-rec, because both instances of pkgs (extended or not) will have the same stdenv. Does the inf-rec go away if you explicitly define the enable option or temporarily remove the isLinux autoEnable? That'd rule out whether that is the actual issue.

Also, in hindsight, I'm not convinced my earlier feedback was needed. In theory, the final passed to the overlay function should be the same thing as the pkgs instance available via module args...

I'd like to rule out the enable option using an (unrelated) part of pkgs from being an actual problem before looking into alternative designs.

Note that the overlay is only necessary on NixOS: GNOME Shell is not installed by Home Manager, so there is never a need for the overlay to be enabled there. Maybe that makes it easier to avoid the infinite recursion.

hmm I don't know how we would tell if the overlay is being used as part of NixOS or home-manager.

having enable condition depend on pkgs is making the overlay inf recurse

I don't see where an enable condition depends on pkgs?

in /modules/gnome/hm.nix

Ah, so the issue is the enable option defaults to config.stylix.autoEnable && pkgs.stdenv.hostPlatform.isLinux, but the same enable option is deciding whether or not pkgs is extended with the overlay.

I'm not convinced that should be inf-rec, because both instances of pkgs (extended or not) will have the same stdenv. Does the inf-rec go away if you explicitly define the enable option or temporarily remove the isLinux autoEnable? That'd rule out whether that is the actual issue.

replacing pkgs.stdenv.hostPlatform.isLinux with true seems to get rid of the issue.

Also, in hindsight, I'm not convinced my earlier feedback was needed. In theory, the final passed to the overlay function should be the same thing as the pkgs instance available via module args...

with the hm enable con set to true it seems like there isn't inf-rec from using the pkgs in the module args.

Thanks for investigating!

That's frustrating, as I'm sure you'll run into this again with other overlays being conditional on a pkgs attr.

While you can work-around the issue by only importing the overlay portion of the module on NixOS, you may not have that luxury in other cases.