Skip to content

Add support for LoongArch64 #2023

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from
Closed

Add support for LoongArch64 #2023

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
8e8956f
Update linux.rs
donmor Apr 17, 2023
2738853
Update .cirrus.yml
donmor Apr 17, 2023
e3d9810
Update .cirrus.yml
donmor Apr 17, 2023
7846bb4
Update Cross.toml
donmor Apr 17, 2023
f7e2f55
Update linux.rs
donmor Jul 21, 2024
b29b8b1
Update Cross.toml
donmor Jul 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .cirrus.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,6 +105,9 @@ task:
- name: Linux i686 musl
env:
TARGET: i686-unknown-linux-musl
- name: Linux LoongArch64
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add this here, Nix has switched to GitHub action for most CI checks:

nix/.github/workflows/ci.yml

Line 94 in 50e4283

powerpc64le-unknown-linux-gnu,

env:
TARGET: loongarch64-unknown-linux-gnu
- name: Linux MIPS
env:
TARGET: mips-unknown-linux-gnu
Expand Down
2 changes: 2 additions & 0 deletions Cross.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,3 +3,5 @@ passthrough = [
"RUSTFLAGS",
"RUST_TEST_THREADS"
]
[target.loongarch64-unknown-linux-gnu]
image = "ghcr.io/loongarchlinux/archlinux:latest"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like Loongarch has been supported by cross, is this custom image still needed?

1 change: 1 addition & 0 deletions src/sys/ioctl/linux.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@ mod consts {
target_arch = "s390x",
target_arch = "x86_64",
target_arch = "aarch64",
target_arch = "loongarch64",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you guys please check what are currently supported and what are not? And, if there is still a lot of work to do, and you guys don't mind, a tracking issue would be appreciated:)

target_arch = "riscv32",
target_arch = "riscv64"
))]
Expand Down