Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AppVeyor: Test and support versions 8, 10, 12, 14, 16, 17, 18, 19, 20, 21, and 22 #983

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented Feb 5, 2025

Tested versions 8, 10, 12, 14, 16, 17, 18, 19, 20, 21, and 22.

Test supported Node.js versions before unsupported versions because each test takes ~5 minutes.
Test on the most current Visual Studio possible for each nodejs_version.
Test on the oldest supported Python version when possible (currently py39).
For all supported Node.js versions also test on the newest Python (currently py313).

Test results: https://ci.appveyor.com/project/RodVagg/nan

Visual Studio 2017 image tops out at Python 3.8 which is end-of-life.
Visual Studio 2019 and 2022 images top out at Python 3.13.

node-gyp issues related to nan: https://github.com/nodejs/node-gyp/issues?q=label%3Anodejs%2Fnan

The Node.js v23 tests are commented out waiting for:

The Python 3.12 and 3.13 tests are commented out waiting for:

@kkoopa Your review, please. These changes enable us to focus on the two issues above.

@cclauss cclauss changed the title Test supported versions of Node.js on a supported version of Python AppVeyor: Test on a supported version of Python Feb 7, 2025
@kkoopa
Copy link
Collaborator

kkoopa commented Feb 11, 2025

Thank you. This looks good to me. While I do not think testing on multiple Python versions for the sake of testing Python is necessary, I do not see it hurting apart from longer runtimes. The reason for originally specifying multiple Python versions was just to get it all working with various images and versions.

@cclauss
Copy link
Contributor Author

cclauss commented Feb 11, 2025

I do not think testing on multiple Python versions [ ... ] is necessary.

The real problem is

Please review and merge #985 and make a new npm release.

If long test runtimes (2+ hours) is an issue then please review and merge

Python 3.9 is the oldest version of Python that is supported.
* https://devguide.python.org/versions
@cclauss cclauss changed the title AppVeyor: Test on a supported version of Python AppVeyor: Test and support versions 8, 10, 12, 14, 16, 17, 18, 19, 20, 21, and 22 Feb 14, 2025
@cclauss
Copy link
Contributor Author

cclauss commented Feb 14, 2025

@kkoopa Your review, please. This puts README.md, AppVeyor, and GitHub Actions in sync on which versions to test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants