Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

package.json: Upgrade node-gyp to support Python >= v3.12 #985

Closed
wants to merge 1 commit into from

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented Feb 7, 2025

https://github.com/nodejs/node-gyp?tab=readme-ov-file#installation says

Important

Python >= v3.12 requires node-gyp >= v10

Fixes: #986

package.json:

-    "node-gyp": "~8.4.1",
+    "node-gyp": "~v10.3.1",

Provides compatibility with Python 3.12, 3.13, and later.

https://github.com/nodejs/node-gyp/releases

Related to:

@mkrufky Your review, please.

@kkoopa
Copy link
Collaborator

kkoopa commented Feb 12, 2025

Looking at the test output from this, there are a lot of failures on ancient versions. Am I correct in assuming that this is expected. The reason for keeping as old a node-gyp as possible has been to enable testing on these ancient versions. I am prepared to drop them from testing if necessary.

@cclauss
Copy link
Contributor Author

cclauss commented Feb 12, 2025

We should not actively encourage building software on unsupported versions of Node.js, node-gyp, or Python.

We could focus GitHub Actions on testing the versions that actually pass on that CI.

We could retool the AppVeyor tests to cover only the old and ugly versions on nan@v2.22.0 that we cannot get to pass on GitHub Actions using nan@latest.

@cclauss
Copy link
Contributor Author

cclauss commented Feb 13, 2025

Let's move forward with #987 which adds the GitHub Actions tests. Merging that one will autoclose this PR and two others.

Once this is merged, we can then rework the AppVeyor tests in #983 to provide guidance on older versions of Node.js

@kkoopa kkoopa closed this in #987 Feb 13, 2025
@cclauss cclauss deleted the patch-4 branch February 13, 2025 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants