Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: fix process exit listeners not receiving unsettled tla codes #56872

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

src: fix process exit listeners not receiving unsettled tla codes #56872

wants to merge 10 commits into from
+112 −32

Conversation

dario-piotrowicz
Copy link
Contributor

@dario-piotrowicz dario-piotrowicz commented Feb 2, 2025 •
edited
Loading

fix listeners registered via process.on('exit', ... not receiving error code 13 when an unsettled top-level-await is encountered in the code

Fixes: #53551

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Feb 2, 2025
@dario-piotrowicz dario-piotrowicz force-pushed the dario/53551/process-on-exit-unsettled-tlas branch from eef4c1f to 80a0041 Compare February 2, 2025 00:35
@codecov Codecov
Copy link

codecov bot commented Feb 2, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.24%. Comparing base (db4dcc0) to head (14b759a).
Report is 11 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #56872   +/-   ##
=======================================
  Coverage   90.24%   90.24%           
=======================================
  Files         630      630           
  Lines      184921   184909   -12     
  Branches    36185    36187    +2     
=======================================
  Hits       166879   166879           
+ Misses      11065    11058    -7     
+ Partials     6977     6972    -5
Files with missing lines Coverage Δ
lib/internal/bootstrap/node.js 99.57% <100.00%> (-0.01%) ⬇️
src/api/embed_helpers.cc 74.61% <100.00%> (-0.02%) ⬇️
src/api/hooks.cc 84.55% <100.00%> (+0.83%) ⬆️
src/env-inl.h 96.97% <100.00%> (+0.02%) ⬆️
src/env.h 98.14% <ø> (ø)

... and 23 files with indirect coverage changes

joyeecheung
joyeecheung reviewed Feb 4, 2025
View reviewed changes
Copy link
Member

@joyeecheung joyeecheung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. Some comments about the approaches taken.

@dario-piotrowicz dario-piotrowicz force-pushed the dario/53551/process-on-exit-unsettled-tlas branch 3 times, most recently from a717cb0 to b456e86 Compare February 9, 2025 18:13
@dario-piotrowicz dario-piotrowicz force-pushed the dario/53551/process-on-exit-unsettled-tlas branch from b456e86 to 7a48cfd Compare February 9, 2025 19:48
@anonrig anonrig requested a review from jasnell February 12, 2025 00:28
@anonrig anonrig added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Feb 12, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 12, 2025
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
aduh95
aduh95 reviewed Feb 12, 2025
View reviewed changes
aduh95
aduh95 reviewed Feb 12, 2025
View reviewed changes
@aduh95 aduh95 added the request-ci Add this label to start a Jenkins CI on a PR. label Feb 13, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 13, 2025
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
joyeecheung
joyeecheung approved these changes Feb 13, 2025
View reviewed changes
Copy link
Member

@joyeecheung joyeecheung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Feb 15, 2025 •
edited by jasnell
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/65235/ 💛

dario-piotrowicz and others added 5 commits March 1, 2025 16:16
@dario-piotrowicz
src: fix process exit listeners not receiving unsettled tla codes
bbc5cbd 
fix listeners registered via `process.on('exit', ...` not receiving
error code 13 when an unsettled top-level-await is encountered in
the code
@dario-piotrowicz
src: fix process exit listeners not receiving unsettled tla codes
0dc8965 
fix listeners registered via `process.on('exit', ...` not receiving
error code 13 when an unsettled top-level-await is encountered in
the code
@dario-piotrowicz @aduh95
Update doc/api/process.md
a124fbf 
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
@dario-piotrowicz @aduh95
Update doc/api/process.md
422df04 
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
@dario-piotrowicz @aduh95
remove local exitCode variable
e6a3409 
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
@dario-piotrowicz dario-piotrowicz force-pushed the dario/53551/process-on-exit-unsettled-tlas branch from 3779a97 to e6a3409 Compare March 1, 2025 22:29
@aduh95 aduh95 removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 1, 2025
@dario-piotrowicz
Copy link
Contributor Author

@aduh95 I've updated the tests, hopefully this satisfies your asks, please have a look 🙏

@dario-piotrowicz @aduh95
Update test/es-module/test-esm-tla-unfinished.mjs
50e7606 
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Mar 2, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 2, 2025
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/65505/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joyeecheung joyeecheung joyeecheung approved these changes

@jasnell jasnell jasnell approved these changes

@anonrig anonrig anonrig approved these changes

@aduh95 aduh95 aduh95 approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect exitCode when process fails due to circular dependency of dynamic import
6 participants
@dario-piotrowicz @nodejs-github-bot @jasnell @anonrig @joyeecheung @aduh95