Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crypto: add support for intermediate certs in --use-system-ca #57164

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

timja
Copy link
Contributor

@timja timja commented Feb 21, 2025

Fixes #57163

TODO:

  • Extend existing test to validate intermediate certificates
  • Validate that removing the root cert means intermediate isn't trusted - Works fine

Run new test on:

  • macOS
  • Windows
  • Linux

I've tested locally and this is working fine

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/crypto

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem. needs-ci PRs that need a full CI run. labels Feb 21, 2025
@timja timja force-pushed the intermediate-certificates branch from 6250353 to 5624123 Compare February 21, 2025 22:30
@timja timja force-pushed the intermediate-certificates branch from 5624123 to e6d4cc0 Compare February 21, 2025 22:34
@timja timja marked this pull request as ready for review February 22, 2025 10:53
Copy link

codecov bot commented Feb 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.25%. Comparing base (772c609) to head (583c4ce).
Report is 84 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #57164      +/-   ##
==========================================
- Coverage   90.36%   90.25%   -0.11%     
==========================================
  Files         629      630       +1     
  Lines      184308   184920     +612     
  Branches    36010    36187     +177     
==========================================
+ Hits       166544   166903     +359     
- Misses      10910    11059     +149     
- Partials     6854     6958     +104     
Files with missing lines Coverage Δ
src/crypto/crypto_context.cc 65.09% <ø> (ø)

... and 74 files with indirect coverage changes

@timja
Copy link
Contributor Author

timja commented Feb 27, 2025

@joyeecheung / @jasnell as reviewers of the other windows use-system-ca PR do you think you could review this one please?

@timja timja requested a review from joyeecheung March 3, 2025 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem. needs-ci PRs that need a full CI run.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

--use-system-ca support for intermediate certificates on Windows
3 participants