2025-02-26, Version 23.9.0 (Current) #57207
Merged
+5,175
−2,313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
PR-URL: #56971 Refs: https://github.com/nodejs/node/actions/runs/13220154720/job/36904132463?pr=56970 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
PR-URL: #56971 Refs: https://github.com/nodejs/node/actions/runs/13220154720/job/36904132463?pr=56970 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Replace ToLocalChecked uses. PR-URL: #56977 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
PR-URL: #56978 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
the trimming functionality that the dotenv parsing uses currently
only takes into consideration plain spaces (' '), other type of
space characters such as tabs and newlines are not trimmed, this
can cause subtle bugs, so the changes here make sure that such
characters get trimmed as well
Co-authored-by: Yagiz Nizipli <yagiz@nizipli.com>
PR-URL: #56983
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #56984 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Jason Zhang <xzha4350@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
PR-URL: #56985 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
PR-URL: #56955 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
PR-URL: #56804 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Harshitha K P <harshitha014@gmail.com>
PR-URL: #56997 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
PR-URL: #56992 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Since nodejs-private/security-release#56 this process has been automated. PR-URL: #57004 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
- We do not actually need them in PEM format, so just pass them around as X509 direcrtly. - The cached global X509 structures were previously never cleaned up. Clean them up at process teardown. - Use function-local static to ensure thread-safety in initialization. - Add more comments about how the various options differ. PR-URL: #56999 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Also adds current work email to mailmap. PR-URL: #57006 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Jordan Harband <ljharb@gmail.com> Reviewed-By: Jason Zhang <xzha4350@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
PR-URL: #57012 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Previously this would compute the release tag to be something like FIREFOX_134_0.2_RELEASE which would not lead to a valid URL, failing to pull the latest NSS updates from the Firefox release. It should replace all the dots with underscores to compute something like FIREFOX_134_0_2_RELEASE instead. PR-URL: #56843 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
PR-URL: #57015 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #56954 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
PR-URL: #57008 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
PR-URL: #57013 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
The previous phrasing encouraged or did not discourage appending new test cases to existing files - a practice that can reduce the debuggability of the tests over time as they get bigger and bigger, some times thousands of lines long with hundreds of test cases, and make the CI output increasingly difficult to read when one of the test cases fail in a very long test. This patch updates the guideline to explicitly discourage appending test cases this way. Also recommend including an opening comment to describe what the test does to optimize the test towards the scenario when it fails. PR-URL: #57028 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Tierney Cyren <hello@bnb.im>
PR-URL: #57064 Reviewed-By: Jordan Harband <ljharb@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #57026 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #56953 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>
On other platforms, load from the OpenSSL default certificate file and diretory. This is different from --use-openssl-ca in that it caches the certificates on first load, instead of always reading from disk every time a new root store is needed. When used together with the statically-linked OpenSSL, the default configuration usually leads to this behavior: - If SSL_CERT_FILE is used, load from SSL_CERT_FILE. Otherwise load from /etc/ssl/cert.pem - If SSL_CERT_DIR is used, load from all the files under SSL_CERT_DIR. Otherwise, load from all the files under /etc/ssl/certs PR-URL: #57009 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Otherwise it may fail the DCHECK that uses the locked thread as a fast path to get the current thread. PR-URL: #57031 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
PR-URL: #57014 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
The test is spawning the python test runner directly without considering whether the current build is a debug build or not i.e. does not propage the mode parameter when the test is run with --mode=debug, so it always ends up using the release build to run the test even if the test is being run for debug builds. This patch fixes that. PR-URL: #57034 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
PR-URL: #56765 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
PR-URL: #57158 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com>
Event params object can be converted to inspector protocol directly. This also enables binary data, like `Network.dataReceived`, to be sent in the inspector protocol from JavaScript since JSON representation does not support plain binary data. PR-URL: #57027 Reviewed-By: Kohei Ueno <kohei.ueno119@gmail.com>
Add clarification based on discussion with security researcher. Signed-off-by: Michael Dawson <midawson@redhat.com> PR-URL: #57150 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
PR-URL: #56972 Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
PR-URL: #56972 Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
PR-URL: #57177 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
PR-URL: #57177 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
PR-URL: #57178 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com>
PR-URL: #57179 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
PR-URL: #57180 Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
targos
force-pushed
the
v23.9.0-proposal
branch
from
e001060 to
9d2368f
Compare
This comment was marked as off-topic.
This comment was marked as off-topic.
aduh95
approved these changes
Feb 26, 2025
|
Release build: https://ci-release.nodejs.org/job/iojs+release/10839/ |
targos
added a commit
to targos/nodejs.org
that referenced
this pull request
Feb 26, 2025
github-merge-queue bot
pushed a commit
to nodejs/nodejs.org
that referenced
this pull request
Feb 26, 2025
aduh95
pushed a commit
to nodejs/bluesky
that referenced
this pull request
Feb 26, 2025
Refs: nodejs/node#57207 Co-authored-by: targos <targos@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2025-02-26, Version 23.9.0 (Current), @targos
Notable Changes
927d985aa0] - (SEMVER-MINOR) dns: add TLSA record query and parsing (Rithvik Vibhu) #529830236fbf75a] - (SEMVER-MINOR) process: add threadCpuUsage (Paolo Insogna) #56467Commits
f4a82fddb1] - benchmark: add a warmup on bench-openSync (Elves Vieira) #57051b384baa073] - build: print 'Formatting Markdown...' for long task markdown formatting (1ilsang) #57108fec2d50308] - build: add skip_apidoc_files and include QUIC (RafaelGSS) #569415af35d1850] - build: fix GN build failure (Cheng) #5701335f89aa66f] - build: fix GN build of uv (Cheng) #56955e26d4841d1] - cli: allow --cpu-prof* in NODE_OPTIONS (Carlos Espa) #57018b50fc42a99] - crypto: support --use-system-ca on non-Windows and non-macOS (Joyee Cheung) #57009dfdaa92a37] - crypto: fix missing OPENSSL_NO_ENGINE guard (Shelley Vohr) #5701218ea88bcbe] - crypto: cleanup root certificates and skip PEM deserialization (Joyee Cheung) #569998076284f9e] - deps: update cjs-module-lexer to 2.1.0 (Node.js GitHub Bot) #571808644cf3e5a] - deps: update ngtcp2 to 1.11.0 (Node.js GitHub Bot) #571792aceca15d6] - deps: update sqlite to 3.49.1 (Node.js GitHub Bot) #571788421021427] - deps: update ada to 3.1.0 (Node.js GitHub Bot) #5708321d795a5f0] - (SEMVER-MINOR) dns: add TLSA record query and parsing (Rithvik Vibhu) #52983455bf5a0a8] - doc: update options to filehandle.appendFile() (Hasegawa-Yukihiro) #56972f35bd869ee] - doc: add additional caveat for fs.watch (Michael Dawson) #571504413ce7ed3] - doc: fix typo in Windows building instructions (Tim Jacomb) #5715866614cfcf3] - doc: fix web.libera.chat link in pull-requests.md (Samuel Bronson) #57076587112cb08] - doc: remove buffered flag from performance hooks examples (Pavel Romanov) #52607fdc8aeb8a0] - doc: fix 'introduced_in' version in typescript module (1ilsang) #57109b6960499c8] - doc: fix link and history ofSourceMapsections (Antoine du Hamel) #570980de128ca97] - doc: addmodule namespace objectlinks (Dario Piotrowicz) #570935a74568320] - doc: disambiguate pseudo-code statement (Dario Piotrowicz) #5709246df14ddcb] - doc: update clang-cl on Windows building guide (Joyee Cheung) #570874b02fdc72f] - doc: update Xcode version used for arm64 and pkg (Michaël Zasso) #5710478d4e52a52] - doc: fix wrong articles used to address modules (Dario Piotrowicz) #57090ed5671f1bc] - doc: updatemodule.builtinModulessentence (Dario Piotrowicz) #570899de45cbac9] - doc:modules.md: fixdistancedefinition (Alexander “weej” Jones) #57046a7e5ef9e01] - doc: fix wrong verb form (Dario Piotrowicz) #57091c02494f5fe] - doc: fix transpiler loader hooks documentation (Joyee Cheung) #570375b2dfadd40] - doc: add a note aboutrequire('../common')in testing documentation (Aditi) #5695350ba04e214] - doc: recommend writing tests in new files and including comments (Joyee Cheung) #570286951133e1a] - doc: improve documentation on argument validation (Aditi) #5695444dd8a5cc2] - doc: buffer: fix typo onBuffer.copyBytesFrom(offsetoption (tpoisseau) #57015c011271a70] - doc: update cleanup to trust on vuln db automation (Rafael Gonzaga) #57004a6b7bce3a0] - doc: move stability index after history section for consistency (Antoine du Hamel) #569973bc6d626b4] - doc: addsignaltofilehandle.writeFile()options (Yukihiro Hasegawa) #568042990cc8616] - doc: run license-builder (github-actions[bot]) #5698540f3a516bf] - fs: handle UV_ENOTDIR infs.statSyncwiththrowIfNoEntryprovided (Juan José Arboleda) #56996e10ef275e8] - inspector: convert event params to protocol without json (Chengzhong Wu) #57027d6234b4652] - inspector: skip promise hook in the inspector async hook (Joyee Cheung) #57148aa817853cd] - lib: fixup more incorrect ERR_INVALID_ARG_VALUE uses (James M Snell) #57177e08d7d4e53] - lib: fixup incorrect argument order in assertEncoding (James M Snell) #57177f77069b4e0] - meta: bumpactions/setup-pythonfrom 5.3.0 to 5.4.0 (dependabot[bot]) #5686735cdd9b9fe] - meta: bumppeter-evans/create-pull-requestfrom 7.0.5 to 7.0.6 (dependabot[bot]) #568663d61604f2a] - meta: bumpmozilla-actions/sccache-actionfrom 0.0.6 to 0.0.7 (dependabot[bot]) #568650dd0108fc5] - meta: bumpcodecov/codecov-actionfrom 5.0.7 to 5.3.1 (dependabot[bot]) #5686458d70369e3] - meta: bumpstep-security/harden-runnerfrom 2.10.2 to 2.10.4 (dependabot[bot]) #56863dfd42db739] - meta: bumpactions/cachefrom 4.1.2 to 4.2.0 (dependabot[bot]) #568627f5f02ba2b] - meta: bumpactions/stalefrom 9.0.0 to 9.1.0 (dependabot[bot]) #5686085ac02f8d3] - meta: bumpgithub/codeql-actionfrom 3.27.5 to 3.28.8 (dependabot[bot]) #56859d62299b021] - meta: add CODEOWNERS for SQLite (Colin Ihrig) #571472ec4ff17a6] - meta: update last name for jkrems (Jan Martin) #57006ad3c572027] - module: improve error message from asynchronicity in require(esm) (Joyee Cheung) #57126cc1cafd562] - module: allow omitting context in synchronous next hooks (Joyee Cheung) #57056c6ddfa52fb] - (SEMVER-MINOR) process: add threadCpuUsage (Paolo Insogna) #56467ac35106625] - sea: suppress builtin warning with disableExperimentalSEAWarning option (koooge) #57086ef314dc773] - src: fix crash when lazy getter is invoked in a vm context (Chengzhong Wu) #5716890a4de02b6] - src: do not format single string argument for THROW_ERR_* (Joyee Cheung) #57126e0a91f631b] - src: gate all quic behind disabled-by-default compile flag (James M Snell) #571427dd326e3a7] - src: move instead of copy shared pointer in node_blob (Michaël Zasso) #57120e3127b89a2] - src: replace NewFromUtf8 with OneByteString where appropriate (James M Snell) #5709656f9fe7514] - src: portdefineLazyPropertiesto native code (Antoine du Hamel) #5708190875ba0ca] - src: improve error handling in node_blob (James M Snell) #570785414eb48b5] - src: improve error handling in multiple files (James M Snell) #56962286bb84188] - src: fix accessing empty string (Cheng) #57014fa26f83e5b] - src: lock the isolate properly in IsolateData destructor (Joyee Cheung) #570317e2dac9fcc] - src: add self-assigment memcpy checks (Burkov Egor) #56986d8e70dcaa6] - src: improve node::Dotenv trimming (Dario Piotrowicz) #5698341f444fa78] - src: improve error handling in string_bytes/decoder (James M Snell) #56978d0ee8c0a20] - src: improve error handling in process_wrap (James M Snell) #569771a244177a3] - test: add doAppendAndCancel test (Hasegawa-Yukihiro) #5697251dff8b1ae] - test: fix test-without-async-context-frame.mjs in debug mode (Joyee Cheung) #570347c7e9f4d84] - test: make eval snapshot comparison more flexible (Shelley Vohr) #57020315244e59e] - test: simplify test-http2-client-promisify-connect-error (Luigi Pinca) #57144ccf496cff9] - test: improve error output of test-http2-client-promisify-connect-error (Antoine du Hamel) #57135a588066518] - test: add case for unrecognised fields within pjson "exports" (Jacob Smith) #57026b369ad6e45] - test: remove unnecessary assert requiring from tests (Dario Piotrowicz) #570089b98ac6a81] - test: update WPT for urlpattern to ef6d83d789 (Node.js GitHub Bot) #569840a82d27d28] - test: reduce flakiness on test-net-write-fully-async-buffer (Yagiz Nizipli) #56971ab150d7781] - test: remove flakiness on macOS test (Yagiz Nizipli) #56971ccb8c12712] - test,crypto: make tests work for BoringSSL (Shelley Vohr) #57021116c1fe84c] - test_runner: refactor testPlan counter increse (Pietro Marchini) #567652929fc6449] - test_runner: allow special characters in snapshot keys (Carlos Espa) #57017a025d7ba07] - tools: run Linux tests on GitHub arm64 runners as well (Dennis Ameling) #5716273a8514305] - tools: consolidate 'introduced_in' check for docs (1ilsang) #571096cdee545f6] - tools: do not run major-release workflow on forks (Rich Trott) #570641efd74b1b0] - tools: fix release URL computation in update-root-certs.mjs (Joyee Cheung) #56843a9112df8d3] - tools: add support forimport sourcesyntax in linter (Antoine du Hamel) #56992c6d6be2c3b] - typings: fixImportModuleDynamicallyCallbackreturn type (Chengzhong Wu) #57160d922153cbf] - url: improve urlpattern regexp performance (Yagiz Nizipli) #57136