-
-
Notifications
You must be signed in to change notification settings - Fork 6.4k
Provide WSL guidance on download page #7651
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Despite my initial skepticism, I am +1 to making the website simpler for new-comers. |
Some options off the top of my head:
|
Can you give me more idea about what do we have to do in this issue ? Till now what I have concluded that :On the download page of nodejs we need to informWindows users about WSL (Windows Subsystem for Linux) :
What we might do is :a. Renaming "Linux" to "Linux (+ WSL)" |
- Add WSLMessage component to display information about Windows Subsystem for Linux (WSL) - Show WSLMessage only once, directly below the `Download Node.js®` title, when Windows(WIN) is selected in any OS dropdown - Refactor context usage to allow independent OS selection in each dropdown - Register WSLMessage and WindowsWSLMessage in MDX components for use in MDX files - Improve user experience by providing relevant WSL info at the right place and time - Enhanced both for Dark and Light Theme with Blue background and border and glowing theme perfectly matching the ui theme of the website ! Issue nodejs#7651 Signed-off-by: vishal <vishalkumarvkvk988@gmail.com>
- Add WSLMessage component to display information about Windows Subsystem for Linux (WSL) - Show WSLMessage only once, directly below the `Download Node.js®` title, when Windows(WIN) is selected in any OS dropdown - Refactor context usage to allow independent OS selection in each dropdown - Register WSLMessage and WindowsWSLMessage in MDX components for use in MDX files - Improve user experience by providing relevant WSL info at the right place and time - Enhanced both for Dark and Light Theme with Blue background and border and glowing theme perfectly matching the ui theme of the website ! Issue nodejs#7651 Signed-off-by: vishal <vishalkumarvkvk988@gmail.com>
Based on #7758 (review), y'all can see I'm -1 with the idea of having WSL notices within our website. There's no precedence in other major runtimes for something such as WSL to be documented. Have we actually gotten real complaints from users saying they didn't know they could use Linux options within WSL? Also should we really have something on our website? Searching for "nodejs on wsl" 1st search results goes to asn official Microsoft article of how to install Node.js ON WSL; Since WSL is a Microsoft product, shouldn't they specifically state their instructions? Otherwise this goes kinda our directive of not promoting company-products on our downloads page. |
I'm not sure that's true -- WSL isn't just some company's product, it's a core feature of a major OS that we do provide instructions for. |
I still think a notice is the right move, this page is meant to be educating new users on the options available to them, so let's do that (especially when our Windows options are so limited). I don't think whether other runtimes do this or not is really a factor, let's chart our own course and be helpful for our users. |
And to be clear, this is not about teaching users that already are using WSL that they can use the Linux options available. I agree in that situation they probably already know that or can search online. This is about educating new developers who have a Windows box and want to use Node.js that there is another way, using WSL. They aren't going to be able to search for that because they don't know it exists -- a notice is educating them and giving them new knowledge. |
It is a product from Microsoft and it is just (simply put) a virtualization layer. For me it is VM for dummies.
That's not the intent of the page at all -- This page serves one purpose: Provide the main relevant download options for getting Node. Be them installers, binaries or via managers. This page shouldn't sway or teach what users should do on their OSs or not. Be it encouraging to use WSL or not. That's hardly up to us + creates the precedence for then other users to complain "why then there's no banner/instructions for solution X from company/org Y"? -- Not to mention our instructions could get outdated and adds one more thing we gotta maintain. |
I think wether they do or not does show that they might also have considered this topic and opted to not being relevant. Of course, we shouldn't limit ourselves towards what others do, but it is still market research of a sort. |
I get that, but again, that shouldn't be our stance as the project to educate them anything except Node.js. This can also be seen as we taking a stance that users should use A instead of B. We do recommend version managers, but just with the distinction of official versus community-maintained in the prospect of what is probably best for users to download/install Node.js I'm committed with my -1; But willing to change my mind if we have a consensus, meaning other @nodejs/web-infra or @nodejs/nodejs-website members are also +1 to this. 👍 if you want a banner On that note, the banner should not be on the top, but IMO below the Dropdowns and should by minimal, non-invasive, (but easy enough to notice, with strong contrasting colours) and only show if Windows is selected. Otherwise why the hell should we render said banner for macOS or Linux users? |
I strongly disagree with this notion -- actively choosing to make this page less helpful and not educate users about core OS features available to them related to how they could run Node.js seems like a really odd stance to have.
I don't think we're setting that precedent at all, again WSL is a core OS feature for a major OS we already support. If Apple ships a "Windows for Mac" virtualisation layer, we should probably let folks know about that too. And I don't see this as a content maintenance burden, it is a tiny notice for folks on Windows letting them know that WSL is a thing -- I don't think that'll go away, and if it does, it's not exactly a difficult change to remove it. |
This shouldn't be the case and I don't think what is proposed here does that -- all we're doing is saying "by the way you use WSL as an alternative", not saying "don't use Windows, use WSL instead" |
+1, but that's just review feedback on a PR to add such a notice (and I had assumed throughout this discussion we'd only show the banner in relevant context). I don't see this as reason to block the entire idea. |
No, it is not. We don't officially support WSL, it just happens to work because WSL is virtualization of other Linux distributions.
Again, the original intent of said download page isn't for education. There are plenty of guides out there. Users will ask AI or Google "what's the best way to install Node on Windows" and it will possibly say WSL. But it shouldbe the users choice; It is hardly an "educating users" move here, it is not up to the Node project that users should use WSL.
Tiny? Have you seen how big the notice is? It is almost the size of the package manager codebox itself.
Neither I said this; But the banner is prominent enough that will sway users from Windows-native options towards WSL, and that shouldn't be our stance It is actually not even a decision of the @nodejs/nodejs-website team, this is a content decision. And I'd be more inclined on having the @nodejs/tsc giving their 👍 here before we add a Microsoft-owned product as the recommended way with a huge banner on the downloads page. To make it clear, nothing against Microsoft or WSL as a product; There's just no precedence here
Not necessarily, it all depends on how we decide to proceed here. |
Uh oh!
There was an error while loading. Please reload this page.
Moving a convo out of #7650.
@ljharb (in PR Review):
@MattIPv4 (in Issue Comment):
@avivkeller (in Issue Comment):
@MattIPv4 (in Issue Comment):
@ljharb (in Issue Comment):
Not sure quite what the perfect solution is, but we should have a way to educate Windows users about WSL -- both that it is an option to them alongside conventional Windows development using Powershell, and also that if they do want to use WSL they should follow the Linux install options that we provide.
The text was updated successfully, but these errors were encountered: