-
-
Notifications
You must be signed in to change notification settings - Fork 6.4k
Add blog post publishing guidelines #7860
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Matteo Collina <hello@matteocollina.com>
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
cc @nodejs/tsc |
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #7860 +/- ##
=======================================
Coverage 75.44% 75.44%
=======================================
Files 101 101
Lines 8305 8305
Branches 218 218
=======================================
Hits 6266 6266
Misses 2037 2037
Partials 2 2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds a new section to the governance document outlining the process and approvals required for publishing blog posts on the Node.js website.
- Introduces a "Blog post publishing guidelines" section.
- Specifies mandatory steps for scheduling and approvals.
- Defines an exception for minor/patch release announcements.
Comments suppressed due to low confidence (2)
GOVERNANCE.md:94
- [nitpick] Consider adding a comma after "blog posts" for clarity: "The following guidelines apply to all blog posts, except minor or patch release announcements:"
The following guidelines apply to all blog posts except minor or patch release announcements:
GOVERNANCE.md:96
- [nitpick] List items should start with a capital letter—change "each" to "Each" to match sentence casing.
1. each blog post _must_ have a target publishing date and time. If scheduled publishing is not possible, _the author_ (if privileged enough) or another delegated member would be responsible for landing.
Why not putting tsc as code owner ? |
That's an implementation detail, which is governed by governance. This PR updates the governance. |
The following guidelines apply to all blog posts except minor or patch release announcements: | ||
|
||
1. each blog post _must_ have a target publishing date and time. If scheduled publishing is not possible, _the author_ (if privileged enough) or another delegated member would be responsible for landing. | ||
2. each blog post _must_ be approved by @nodejs/tsc members _and_ OpenJS Foundation marketing staff. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we can pull together a nodejs/marketing team that has members from both the TSC and the foundation marketing staff, would it be enough here to say that the nodejs/marketing team must approve it... then that team can work out whatever process makes the most sense to it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does https://github.com/orgs/nodejs/teams/social suffice?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jasnell if both the TSC and OpenJS staff are members of the team, technically the TSC could approve this without asking them. This has a different meaning.
I wonder if we should label the blog posts somehow differently between "official" content and community content, and give project contributors sufficient trust to manage the community content. Putting an approval chain on every blog post gives me the "you need to get approval from the management for everything you do" megacorp vibes and seems out of place for a community-driven OSS project. |
What kind of community content are we publishing on this blog? The vast majority posts are releases, and the rest are various kind of official announcements that represents the project in one form or another. |
After discussing with @rginn, I'm adding the updated guidelines for publishing blog posts on the Node.js website.