fix: fix EnvHttpProxyAgent for the Node.js bundle #4064
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Dispatcher needs some methods from lib/api for EnvHttpProxyAgent, otherwise it's incomplete.
joyeecheung
commented
Feb 21, 2025
|
Can you add a test for it? |
metcoder95
approved these changes
Feb 23, 2025
|
Added a test - I didn't use mocks but spin up two servers to try to exercise more paths, in case the mocks hide any real issues in the paths that would be otherwise exercised if used for real. Also I just wrote the test to use them together since nodejs/node#57165 doesn't need them exposed individually. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This relates to...
Refs: nodejs/node#57165
Rationale
The Dispatcher needs some prototype methods from lib/api for EnvHttpProxyAgent, otherwise it's incomplete, and throws a
TypeError: this[kClient].connect is not a functionwhenEnvHttpProxyAgentis handling requests inside the Node.js bundle.Changes
Make the Dispatcher prototype complete in the Node.js bundle.
Features
Bug Fixes
Breaking Changes and Deprecations
Status