-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding scripts for using the NCEDC data stored on s3 #283
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #283 +/- ##
==========================================
+ Coverage 75.81% 75.86% +0.04%
==========================================
Files 39 40 +1
Lines 4425 4483 +58
Branches 603 606 +3
==========================================
+ Hits 3355 3401 +46
- Misses 925 934 +9
- Partials 145 148 +3 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comments about the tests, also please remove the 3 data files that got added.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kuanfufeng @mdenolle Do you want to add this new notebook to the tutorials/_toc.html
? This would make it appear on the docs, but also make sure that it's tested on every PR.
@kuanfufeng I suggest adding That will prevent tests data from accidentally getting added to the repo later on. |
Right, but I saw it has been added by your previous commit. Do you want it updated with |
That sounds good. I saw an editing of |
I think it's better to add it here, since this PR is the one adding the notebook and using these data directory. Keeps the PRs more cohesive. E.g. what is #284 ends up not getting merged? Granted, this will likely require a merge at some point, but will be a pretty simple one. |
This PR is for adding scripts/functions and a tutorial for using the NCEDC data stored on s3.
NCEDCS3DataStore
by refactoring a base a common base class fromSCEDCS3DataStore
noisepy_ncedc_tutorial.ipynb
for the tutorial