chore: Precommit check for notebook outputs #285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlosgjs
requested review from
mdenolle,
niyiyu and
chengxinjiang
as code owners
carlosgjs
temporarily deployed
to
github-pages
GitHub Actions
Inactive
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #285 +/- ##
=======================================
Coverage 75.81% 75.81%
=======================================
Files 39 39
Lines 4425 4425
Branches 603 603
=======================================
Hits 3355 3355
Misses 925 925
Partials 145 145 ☔ View full report in Codecov by Sentry. |
carlosgjs
temporarily deployed
to
github-pages
GitHub Actions
Inactive
mdenolle
approved these changes
Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A best practice for Jupyter notebooks in git is to clear the outputs before committing them to the repo. This PR automates this via a
pre-commitstep and cleans up the existing notebooks.