Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add substack_windows config parameter #297

Closed
wants to merge 1 commit into from

Conversation

carlosgjs
Copy link
Collaborator

@mdenolle , this is how I would suggest addressing issue noisepy/noisepy-io#36 .

However, it would be better to do this once Ishika finishes her refactoring because datatypes.py has moved to the noisepy-io repo.

@IshikaKhandelwal - fyi

Copy link

codecov bot commented Feb 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.97%. Comparing base (6a44a88) to head (caf529a).
Report is 66 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #297      +/-   ##
==========================================
+ Coverage   75.91%   75.97%   +0.06%     
==========================================
  Files          40       40              
  Lines        4480     4483       +3     
  Branches      605      605              
==========================================
+ Hits         3401     3406       +5     
+ Misses        932      931       -1     
+ Partials      147      146       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@niyiyu
Copy link
Collaborator

niyiyu commented Oct 24, 2024

Addressing in IO package. noisepy/noisepy-io#37

@niyiyu niyiyu closed this Oct 24, 2024
@niyiyu niyiyu deleted the carlosg/substack branch October 24, 2024 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants