Update monitoring methods #311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #311 +/- ##
==========================================
- Coverage 83.78% 83.52% -0.27%
==========================================
Files 9 9
Lines 2054 1973 -81
Branches 342 330 -12
==========================================
- Hits 1721 1648 -73
+ Misses 212 207 -5
+ Partials 121 118 -3 ☔ View full report in Codecov by Sentry. |
…xtremely similar signals
kuanfufeng
requested review from
mdenolle,
niyiyu,
carlosgjs and
chengxinjiang
as code owners
koepflma
pushed a commit
that referenced
this pull request
Jun 21, 2024
* update monitoring methods with Congcongs latest dvv_modules * update monitoring methods notebook information * replace kernelspec * Add a module back to the methods * Add modules back to the methods * update monitoring methods scripts * update test scripts of monitoring_utils * update test scripts for monitoring methods * replace kernelspec * replace kernelspec * Fix the negative estimated error problem by considering the case of extremely similar signals * update notebook accordingly * remove the unused method * replace print with logger.warning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the monitoring methods with Congcong Yuan's latest version, as in his GJI paper. Also, update the notebook and those testing scripts accordingly.
This PR also fixes the negative error issue in the stretching method.