Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pull] master from jitsi:master #36

Open
wants to merge 211 commits into
base: master
Choose a base branch
from
Open

[pull] master from jitsi:master #36

wants to merge 211 commits into from

Conversation

pull[bot]
Copy link

@pull pull bot commented Mar 18, 2023

See Commits and Changes for more details.


Created by pull[bot]

Can you help keep this open source service alive? 💖 Please sponsor : )

bgrozev and others added 4 commits March 15, 2023 10:29
A bump to 2.2 was intended with the mono repo changes, but it was only
partially done (a v2.2 tag exists, but pom.xml still lists 2.1).
…2003)

* feat: Support setting the initial value of last-n through colibri2.

* fix: initial-last-n only has effect before constraints are received.

* chore: Update jitsi-xmpp-extensions.
* Move SctpHandler and DataChannelHandler out of Endpoint.

* Add datachannel support for relay message transport.

* Put sctp in transport response if it was in the request.

* Update docs to mention that relays can use SCTP.

* Don't advertise websockets for relay connections if told to use data channels in the signaling.

* Fix typo in exception message.
@pull pull bot added the ⤵️ pull label Mar 18, 2023
@codecov-commenter
Copy link

Codecov Report

Patch coverage: 7.01% and project coverage change: -0.12 ⚠️

Comparison is base (1c5748a) 43.14% compared to head (7a3271b) 43.03%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@             Coverage Diff              @@
##             master      #36      +/-   ##
============================================
- Coverage     43.14%   43.03%   -0.12%     
- Complexity     1675     1677       +2     
============================================
  Files           323      325       +2     
  Lines         16740    16888     +148     
  Branches       2202     2227      +25     
============================================
+ Hits           7222     7267      +45     
- Misses         8808     8910     +102     
- Partials        710      711       +1     
Impacted Files Coverage Δ
...n/java/org/jitsi/videobridge/sctp/SctpManager.java 0.00% <0.00%> (ø)
.../src/main/kotlin/org/jitsi/videobridge/Endpoint.kt 20.50% <0.00%> (+0.03%) ⬆️
.../videobridge/colibri2/Colibri2ConferenceHandler.kt 1.16% <0.00%> (-0.11%) ⬇️
...g/jitsi/videobridge/relay/RelayMessageTransport.kt 7.92% <4.76%> (-1.18%) ⬇️
...c/main/kotlin/org/jitsi/videobridge/relay/Relay.kt 16.63% <7.00%> (-1.40%) ⬇️
...n/org/jitsi/videobridge/sctp/DataChannelHandler.kt 12.50% <12.50%> (ø)
...n/kotlin/org/jitsi/videobridge/sctp/SctpHandler.kt 17.39% <17.39%> (ø)

... and 5 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

JonathanLennox and others added 24 commits March 20, 2023 11:57
…n endpoint error (#1999)

* Added functionality to send back UNKNOWN_ENDPOINT Colibri2Error when there is no such endpoint. This addition reason will help jicofo to recognise this colibri2 error and re-invite participant instead of invalidating whole bridge and re-inviting all participants.

* ref: Move UnknownEndpointException definition.

* Update jitsi-xmpp-extensions.

* feat: Return feature_not_implemented for colibri2 requests

that use features known not to be properly supported by jitsi-videobridge
(and not used in jicofo). This is mostly to help spot problems early if
developing a different colibri2 client (not jicofo).

* feat: Suppress UNKNOWN_ENDPOINT errors for some requests

When the request is just trying to expire and endpoint or relay that is
missing (presumably already expired) we don't need to throw an error.
Same if the request only updates the force-mute state of an endpoint
(the only other operation that is currently performed in a batch by
jicofo).

Other requests, which create an endpoint/relay or update the
media/sources/transport of an endpoint still throw UNKNOWN_ENDPOINT
erorrs. These requests are now required to reference a single endpoint
or relay (to simplify error handling).

---------

Co-authored-by: Boris Grozev <boris@jitsi.org>
* Put assumed-bandwidth-bps behind a config flag.
…ints. (#2010)

* Call conference.addEndpoints() a single time when adding RelayedEndpoints.
Even if it has no participants - it might be bridging to a visitor relay.
* Add meshId to debug state.
* Add stats for packet/byte count organized by conference size.
* Update to Jetty 11.0.14.

(Including jicoco dependency.)

* Bump jicoco, and jersey version.

This also necessitated bumping junit and kotest versions for tests, and fixing one test syntax.

* Exclude some spotbugs errors from new kotest.

* Pull in the correct junit-jupiter-api version.

* Fix some deprecated kotest API usages.
* Remove unnecessary try/catch.

* Actually return health check result.
)

This fixes inter-relay bridge channels when SCTP datachannels are disabled.
…ot send for screensharing. (#2017)

* fix: Fix sending preemptive keyframe requests with source names, do not send for screensharing.
Fixes finding the AudioSourceDesc when it belongs to a RelayedEndpoint.
The Relay already has its ID in the context resulting in:
relayId=jvb-foo-bar relay-id=jvb-foo-bar
or suspiciously high, or the sender's "delay since last SR" values is
too high.
Disable some rules that are annoying.

Corresponding code format changes (should be no substantive change).
JonathanLennox and others added 30 commits December 3, 2024 10:35
* feat: Add a metric for XMPP disconnects.

* chore: Update jicoco to 1.1-148 (enable XMPP SM)
  feat: Add an endpointId field to StartEvent.
  feat: Move jwt utils from jibri into jicoco-jwt.
  chore: Update jitsi-metaconfig.
  Add Java 21 to GitHub testing matrix
  feat: Enables stream resumption.
* chore: Adapt to jicoco changes.
A reconnect fix on startup a race may lead to keep trying to  reconnect filling up the logs with:
WARNING: [25] [hostname=localhost id=shard] MucClient.lambda$getConnectAndLoginCallable$9#693: Error connecting:
org.jivesoftware.smack.SmackException$AlreadyConnectedException: Client is already connected
* fix: Fail early if IMDS returns an error. (jitsi/ice4j#298)
  * Add IMDSv2 support to AwsCandidateHarvester and replace URLConnectionn with HttpRequest (jitsi/ice4j#297)
  * Add Java 21 to GitHub testing matrix (jitsi/ice4j#296)
* feat: Add BitReader utilities and tests.
* feat: Add a parser for the VLA RTP header extension.
* ref: Remove unused function.
* feat: Update layers with info found in VLA.
* feat: Add an option to use targetBitrate instead of measured bitrate for allocation
* feat: Warn if replacing width/frameRate.
* test: Add tests for invalid VLAs.
* ref: Simplify code, add a comment.
* feat: Retain the VLA extension between relays.
#2266)

Bumps [com.google.guava:guava](https://github.com/google/guava) from 33.2.0-jre to 33.4.0-jre.
- [Release notes](https://github.com/google/guava/releases)
- [Commits](https://github.com/google/guava/commits)

---
updated-dependencies:
- dependency-name: com.google.guava:guava
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Emmanuel Ferdman <emmanuelferdman@gmail.com>
… 3.2.5 to 3.5.2 in /jvb (#2245)

chore(deps): Bump org.apache.maven.plugins:maven-surefire-plugin in /jvb

Bumps [org.apache.maven.plugins:maven-surefire-plugin](https://github.com/apache/maven-surefire) from 3.2.5 to 3.5.2.
- [Release notes](https://github.com/apache/maven-surefire/releases)
- [Commits](apache/maven-surefire@surefire-3.2.5...surefire-3.5.2)

---
updated-dependencies:
- dependency-name: org.apache.maven.plugins:maven-surefire-plugin
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
… 3.2.5 to 3.5.2 in /rtp (#2246)

chore(deps): Bump org.apache.maven.plugins:maven-surefire-plugin in /rtp

Bumps [org.apache.maven.plugins:maven-surefire-plugin](https://github.com/apache/maven-surefire) from 3.2.5 to 3.5.2.
- [Release notes](https://github.com/apache/maven-surefire/releases)
- [Commits](apache/maven-surefire@surefire-3.2.5...surefire-3.5.2)

---
updated-dependencies:
- dependency-name: org.apache.maven.plugins:maven-surefire-plugin
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
… 3.2.5 to 3.5.2 in /jitsi-media-transform (#2244)

chore(deps): Bump org.apache.maven.plugins:maven-surefire-plugin

Bumps [org.apache.maven.plugins:maven-surefire-plugin](https://github.com/apache/maven-surefire) from 3.2.5 to 3.5.2.
- [Release notes](https://github.com/apache/maven-surefire/releases)
- [Commits](apache/maven-surefire@surefire-3.2.5...surefire-3.5.2)

---
updated-dependencies:
- dependency-name: org.apache.maven.plugins:maven-surefire-plugin
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…e preferred frame rate. (#2268)

Correctly calculate temporal layers' frame rates from VLA (presuming 2:1 ratios).
…om 3.1.1 to 3.6.0 (#2239)

chore(deps): Bump org.apache.maven.plugins:maven-checkstyle-plugin

Bumps [org.apache.maven.plugins:maven-checkstyle-plugin](https://github.com/apache/maven-checkstyle-plugin) from 3.1.1 to 3.6.0.
- [Commits](apache/maven-checkstyle-plugin@maven-checkstyle-plugin-3.1.1...maven-checkstyle-plugin-3.6.0)

---
updated-dependencies:
- dependency-name: org.apache.maven.plugins:maven-checkstyle-plugin
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [io.sentry:sentry](https://github.com/getsentry/sentry-java) from 7.14.0 to 7.20.0.
- [Release notes](https://github.com/getsentry/sentry-java/releases)
- [Changelog](https://github.com/getsentry/sentry-java/blob/main/CHANGELOG.md)
- [Commits](getsentry/sentry-java@7.14.0...7.20.0)

---
updated-dependencies:
- dependency-name: io.sentry:sentry
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps `jetty.version` from 11.0.21 to 11.0.24.

Updates `org.eclipse.jetty:jetty-rewrite` from 11.0.21 to 11.0.24

Updates `org.eclipse.jetty:jetty-servlets` from 11.0.21 to 11.0.24

Updates `org.eclipse.jetty.websocket:websocket-jetty-server` from 11.0.21 to 11.0.24

Updates `org.eclipse.jetty.websocket:websocket-jetty-client` from 11.0.21 to 11.0.24

Updates `org.eclipse.jetty:jetty-maven-plugin` from 11.0.21 to 11.0.24

---
updated-dependencies:
- dependency-name: org.eclipse.jetty:jetty-rewrite
  dependency-type: direct:production
  update-type: version-update:semver-patch
- dependency-name: org.eclipse.jetty:jetty-servlets
  dependency-type: direct:production
  update-type: version-update:semver-patch
- dependency-name: org.eclipse.jetty.websocket:websocket-jetty-server
  dependency-type: direct:production
  update-type: version-update:semver-patch
- dependency-name: org.eclipse.jetty.websocket:websocket-jetty-client
  dependency-type: direct:production
  update-type: version-update:semver-patch
- dependency-name: org.eclipse.jetty:jetty-maven-plugin
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps `slf4j.version` from 2.0.13 to 2.0.16.

Updates `org.slf4j:slf4j-api` from 2.0.13 to 2.0.16

Updates `org.slf4j:slf4j-jdk14` from 2.0.13 to 2.0.16

---
updated-dependencies:
- dependency-name: org.slf4j:slf4j-api
  dependency-type: direct:production
  update-type: version-update:semver-patch
- dependency-name: org.slf4j:slf4j-jdk14
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* feat: Add stats for bandwidth probing to debug (rtcstats).

* fix: Use observed bitrate instead of encoder target when calculating probing needed.

* fix: Do not probe if the ideal layers are already selected.

* ref: Remove unused vals.
Co-authored-by: Daniil Meitis <daniil.meitis@viber.com>
…ormation. (#2284)

It will change when a screenshared window's size is changed.
)

* fix: Sources with type NONE should not have effective constraints.

When a source has video type NONE or DISABLED, it has been signaled but
is not transmitted. For the purpose of generating effective constraints,
it should be as if the source was not present.

A change of effective constraints is the trigger for creating a new
mapping for a receiver. If a receiver has effective constraints for a
source with type NONE, and that source is later enabled, the effective
constraints don't change, and the mapping is not created. This should
fix #2288.

* squash: Adjust unit tests.
Remove Debian post-install logic that uses usrsctp on ppc64le.
Fixes infinite loop printing "MucClient.lambda$getConnectAndLoginCallable$9#693: Already connected.".
…2298)

Otherwise stripped header extensions aren't stripped in the packet cache.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.