Add missing STBIRDEF to allow multiple stb_image_resize2.h implementations #1739
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following code that includes the STB image resize implementation in multiple files will fail:
a.cpp:
b.cpp:
main.cpp:
Compile with
and you get
The fix is easy: just a missing
STBIRDEF
in front of some simd constant variables, so that they are defined withstatic
and can be included in multiple translation units ifSTB_IMAGE_RESIZE_STATIC
is defined. Once the fix in this PR is applied, the test program links happily.Thanks so much for STB! We use it inside of mlpack to provide image support for machine learning tasks.