Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: ROS Diagnostics #3

Open
icolwell-as opened this issue Jun 25, 2020 · 5 comments
Open

Feature Request: ROS Diagnostics #3

icolwell-as opened this issue Jun 25, 2020 · 5 comments
Labels
enhancement New feature or request

Comments

@icolwell-as
Copy link

It would be handy if the driver published diagnostic messages.

@novatel-applications-engineering
Copy link
Contributor

@icolwell-as, thank you for this request. Can you please describe what type of status info you would like to be published through the diagnostic package?

@icolwell-as
Copy link
Author

icolwell-as commented Jul 8, 2020

Here are a few ideas off the top of my head:

  • Publish topic status messages for each requested novatel message/ros topic (diagnostic_updater is useful for this). I believe something similar is already done by the driver and sent to rosout.
  • A DiagnosticStatus message that represents the connection to the receiver (if it's connected or not)
  • A DiagnosticStatus message for the current solution status, and other pertinent receiver status information like number of satellites tracked, etc.

Might also be a good idea to look at other opensource ROS drivers to get a feel for how they use diagnostics.
https://github.com/ros-drivers
I think a lot of the camera drivers use diagnostics.

@novatel-applications-engineering
Copy link
Contributor

Thank you @icolwell-as, we're looking in to this possibly being added to our next release of this driver.

@novatel-applications-engineering novatel-applications-engineering added the enhancement New feature or request label Aug 12, 2020
@Timple
Copy link

Timple commented Sep 22, 2020

For us it would be useful to see IF rtcm data is flowing in. And IF this rtcm data is successfully applied.
This would be typical data for a diagnostics item.

@MCFurry
Copy link

MCFurry commented Apr 22, 2021

It would also be really helpful if the status field of the NavSatFix message (/gps/fix) would be populated. This field is of type NavSatStatus and hence resembles the fix-status and gnss-services in use.
At this moment it is not and we have to get this information from other Novatel topics.

Edit:
Actually, this is not directly related to diagnostics, so let me make a separate issue for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants