semistandard

Author: trufae

index.js

@@ -50,7 +50,7 @@ class Applesign {
   async getDeviceProvision () {
     const installedProvisions = await tools.ideviceprovision('list');
     const pd = path.join(homedir(), 'Library', 'MobileDevice', 'Provisioning Profiles');
-    for (let ip of installedProvisions) {
+    for (const ip of installedProvisions) {
       const absPath = path.join(pd, ip + '.mobileprovision');
       if (fs.existsSync(absPath)) {
         return absPath;
@@ -344,11 +344,11 @@ class Applesign {
         this.emit('message', 'Using an unsigned provisioning');
         const newEntitlementsFile = file + '.entitlements';
         const newEntitlements = plistBuild(entMacho).toString();
-        const tmpEmtitlementsFile = this._pathInTmp(newEntitlementsFile);
-        fs.writeFileSync(tmpEmtitlementsFile, newEntitlements);
-        this.config.entitlement = tmpEmtitlementsFile;
+        const tmpEntitlementsFile = this._pathInTmp(newEntitlementsFile);
+        fs.writeFileSync(tmpEntitlementsFile, newEntitlements);
+        this.config.entitlement = tmpEntitlementsFile;
         if (!this.config.noEntitlementsFile) {
-          fs.writeFileSync(newEntitlementsFile, tmpEntitlements);
+          fs.writeFileSync(newEntitlementsFile, tmpEntitlementsFile);
         }
         this.debugInfo(file, 'newEntitlements', plist.parse(newEntitlements));
         return;
@@ -701,10 +701,10 @@ class Applesign {
       if (this.config.all) {
         libraries.push(...ls.orphanedLibraries());
       } else {
-        for (let ol of ls.orphanedLibraries()) {
+        for (const ol of ls.orphanedLibraries()) {
           console.error('Warning: Orphaned library not signed, try -a: ' + ol);
         }
-      }
+      }
       this.debugInfo('analysis', 'orphan', ls.orphanedLibraries());
       // const libraries = ls.diskLibraries ();
       libs = libraries.filter(library => !(ls.appexs.includes(library))); // remove already-signed appexs

lib/config.js

@@ -221,7 +221,7 @@ function parse (argv) {
       'P', 'parallel',
       'S', 'self-signed-provision',
       'V', 'verify-twice',
-      'Z', 'pseudo-sign'
+      'Z', 'pseudo-sign',
       'a', 'all',
       'c', 'clone-entitlements',
       'f', 'force-family',
@@ -235,7 +235,7 @@ function parse (argv) {
       'v', 'verify',
       'w', 'without-watchapp',
       'x', 'without-xctests',
-      'z', 'ignore-zip-errors',
+      'z', 'ignore-zip-errors'
     ]
   });
 }
@@ -292,6 +292,6 @@ module.exports = {
   fromOptions: fromOptions,
   fromState: fromState,
   helpMessage: helpMessage,
-  parse: parse
-  shortHelpMessage: shortHelpMessage,
+  parse: parse,
+  shortHelpMessage: shortHelpMessage
 };

lib/tools.js

@@ -95,12 +95,13 @@ function getTool (tool) {
 }
 
 async function ideviceprovision (action, optarg) {
-  switch (action) {
-  case 'list':
+  if (action === 'list') {
     const res = await execProgram(getTool('ideviceprovision'), ['list'], null);
     return res.stdout.split('\n')
       .filter((line) => line.indexOf('-') !== -1)
       .map((line) => line.split(' ')[0]);
+  } else {
+    throw new Error('unsupported ideviceprovision action');
   }
 }
 
@@ -119,7 +120,7 @@ async function codesign (identity, entitlement, keychain, file) {
   if (typeof keychain === 'string') {
     args.push('--keychain=' + keychain);
   }
-  args.push('--generate-entitlement-der')
+  args.push('--generate-entitlement-der');
   args.push(file);
   return execProgram(getTool('codesign'), args, null);
 }