Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass in a node list and not just one HTMLElement #4

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mikkoh
Copy link

@mikkoh mikkoh commented Oct 16, 2014

Sometimes you want to add lets say a click event to an entire NodeList.

require( 'dom-select' ).all( 'something' )

Returns a NodeList.

@azer
Copy link

azer commented Oct 16, 2014

@mikkoh can we make this a separate module to keep this module plain & simple ? I can add u to the organization for letting u create repos

@mikkoh
Copy link
Author

mikkoh commented Oct 16, 2014

Sure sounds good. Do you for see this being a breaking feature for dependents? Or is there some other reason why you wouldn't want to implement passing in a NodeList?

@mikkoh
Copy link
Author

mikkoh commented Oct 16, 2014

I understand it can be a slippery slope where then next you want to implement if someone passes an Array etc etc. And then you end up with jQuery. But I see selecting NodeList and HTMLElement to be super similar. Hmmm...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants