Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CSRF Protection for admin stuff #35

Closed
Lamby777 opened this issue May 15, 2023 · 1 comment
Closed

CSRF Protection for admin stuff #35

Lamby777 opened this issue May 15, 2023 · 1 comment
Labels
enhancement New feature or request security Security-related issues

Comments

@Lamby777
Copy link
Member

Haven't even made a UI control panel yet, so this doesn't really apply right now, but later on, there should be anti-CSRF measures to prevent any old Joe from sending an admin a sussy link to one of the /cpl routes.
@Lamby777 Lamby777 added enhancement New feature or request security Security-related issues labels May 15, 2023
@Lamby777 Lamby777 pinned this issue May 19, 2023
@Lamby777
Copy link
Member Author

Lamby777 commented Sep 5, 2024

No longer relevant. Control panel is gone for now, and all important requests are done over POST and cookies are marked HTTP Only. Not sure if there are any other ways to harden against CSRF for now, but maybe will revisit this when adding an admin panel again after Rooms is complete

@Lamby777 Lamby777 closed this as completed Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request security Security-related issues
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Lamby777